Support non-monospace/monospace font rendering #207

BeichenDream · 2021-07-01T17:52:20Z

Fix bug
issue

BeichenDream · 2021-07-01T17:55:43Z

Now it supports the rendering of non-monospaced fonts

segrey · 2021-07-02T10:39:10Z

@BeichenDream Seems most changes in TerminalPanel.java are caused by different formatting options (4 spaces instead of 2, etc.) Could you please adjust your formatting options to keep meaningful changes only?

BeichenDream · 2021-07-02T10:44:47Z

@BeichenDream Seems most changes in TerminalPanel.java are caused by different formatting options (4 spaces instead of 2, etc.) Could you please adjust your formatting options to keep meaningful changes only?

Do you mean code style?

segrey · 2021-07-02T10:56:31Z

Yes, code style

fix code style

BeichenDream · 2021-07-02T11:49:33Z

Yes, code style

Now that the code has been fixed, you can test it

segrey · 2021-07-02T12:21:00Z

@BeichenDream Unfortunately, the diff is still large (3216 lines). Can you please checkout the original TerminalPanel, apply your changes and push it without reformatting the whole file?

fix code style

BeichenDream · 2021-07-02T13:10:51Z

Alright, I have manually fixed the code style now. Now you can test the code.

segrey · 2021-07-02T13:35:47Z

terminal/src/com/jediterm/terminal/ui/TerminalPanel.java

@@ -1079,11 +1120,11 @@ void drawCursor(String c, Graphics2D gfx, TextStyle style) {
      }

      CharBuffer buf = new CharBuffer(c);
-      int xCoord = x * myCharSize.width + getInsetX();
+      int xCoord = computexCoord(x, y) + getInsetX();


Unfortunately, it will cost some performance, because now painting (height,width) panel would require approximately (height * width * width) / 2 calls of gfx.getFontMetrics(font).charWidth(<char>).

Yes, this is a must for non-monospaced fonts;

There is another point that can be cached after rendering. If Terminal does not receive keyboard messages or mouse messages or the size of the window changes, you can directly return the results of the last rendering. This can solve the performance problem.

For me, the rendering of non-monospaced fonts is necessary because it is impossible for our program to carry font files of dozens of megabytes.

You can build jediterm.jar from your fork and use it as a workaround. When proper support for non-monospaced is added, you can remove your fork. Will it work for you?

You can build jediterm.jar from your fork and use it as a workaround. When proper support for non-monospaced is added, you can remove your fork. Will it work for you?

I have seen a large number of non-monospaced fonts rendering issues in issues. If you don’t solve it, I think you should understand.

Sorry, not sure I understand: if your software would use jediterm.jar built from your fork, it would solve non-monospaced fonts rendering issues for your users. Right?

Regarding this change, fixing non-monospaced fonts rendering issues as it was suggested in this PR would lead to degraded performance for all fonts. I agree that non-monospaced fonts rendering issues should be fixed, but probably the fix should be more elaborate to not degrade performance for monospaced fonts. No particular plans, but I'll think about it.

Regarding this change, fixing non-monospaced fonts rendering issues as it was suggested in this PR would lead to degraded performance for all fonts. I agree that non-monospaced fonts rendering issues should be fixed, but probably the fix should be more elaborate to not degrade performance for monospaced fonts. No particular plans, but I'll think about it.

Please do not close this PR. I should have time to fix performance issues in the next few months. Add double buffering and rendering cache to it.

Sure, let's keep it open. Not sure double buffering would help here. It seems to me that it's more about improving algorithm of calculating x-position of a cell.

Optimal calculation of X coordinate algorithm
Now it only accounts for 3.6% of the CPU in the entire drawing cycle

The algorithm has been optimized and now only takes up very little CPU

segrey · 2021-07-02T13:41:34Z

Thanks, I see your idea. I think fixing it for non-monospaced fonts shouldn't degrade performance for monospaced fonts.

BeichenDream · 2021-07-02T13:43:56Z

Thanks, I see your idea. I think fixing it for non-monospaced fonts shouldn't degrade performance for monospaced fonts.

Yes, this is a must for non-monospaced fonts;

There is another point that can be cached after rendering. If Terminal does not receive keyboard messages or mouse messages or the size of the window changes, you can directly return the results of the last rendering. This can solve the performance problem.

For me, the rendering of non-monospaced fonts is necessary because it is impossible for our program to carry font files of dozens of megabytes.

You can also create a method in the object TerminalPanel that indicates whether to perform non-monospace font rendering

Optimal calculation of X coordinate algorithm Now it only accounts for 3.6% of the CPU in the entire drawing cycle

BeichenDream · 2021-07-02T19:29:49Z

I think you can merge branches now

segrey · 2021-07-02T19:38:11Z

I've reviewed the lastest commit (99db2b4) and there are still (height * width * width) / 2 calls of gfx.getFontMetrics(font).charWidth(<char>).

BeichenDream

I've reviewed the lastest commit (99db2b4) and there are still (height * width * width) / 2 calls of gfx.getFontMetrics(font).charWidth(<char>).

Yes, this is indispensable at the moment, but it only occupies 3% of the cpu of the drawing cycle. I think it’s good for not being able to render non-monospaced fonts.

BeichenDream · 2021-07-02T19:29:13Z

terminal/src/com/jediterm/terminal/ui/TerminalPanel.java

@@ -1079,11 +1120,11 @@ void drawCursor(String c, Graphics2D gfx, TextStyle style) {
      }

      CharBuffer buf = new CharBuffer(c);
-      int xCoord = x * myCharSize.width + getInsetX();
+      int xCoord = computexCoord(x, y) + getInsetX();


Optimal calculation of X coordinate algorithm
Now it only accounts for 3.6% of the CPU in the entire drawing cycle

BeichenDream · 2021-07-02T19:31:21Z

terminal/src/com/jediterm/terminal/ui/TerminalPanel.java

@@ -1079,11 +1120,11 @@ void drawCursor(String c, Graphics2D gfx, TextStyle style) {
      }

      CharBuffer buf = new CharBuffer(c);
-      int xCoord = x * myCharSize.width + getInsetX();
+      int xCoord = computexCoord(x, y) + getInsetX();


The algorithm has been optimized and now only takes up very little CPU

segrey · 2021-07-02T19:55:41Z

3.6% is not much indeed, however, it'd be great to have 0% for monospaced fonts (if that's possible).
Thanks for your work, having it as a base, I'll improve it further in a few next weeks.

BeichenDream · 2021-07-02T20:01:23Z

3.6% is not much indeed, however, it'd be great to have 0% for monospaced fonts (if that's possible).
Thanks for your work, having it as a base, I'll improve it further in a few next weeks.

I think we should not spend time on this 3.6% trivial matter. I use jvisualvm to analyze the program and found that most of the time and the cpu are executing the sun.java2d.SunGraphics2D.drawChars() method, so we currently optimize the program the most A good way is to increase the cache to reduce painting

BeichenDream · 2021-07-02T20:11:57Z

In fact, we have now removed the calculation of wide characters, so it is faster than the original program.

Fix the pull-up progress bar cannot be rendered, reduce useless code calculations

BeichenDream · 2021-07-03T22:41:56Z

Fix the pull-up progress bar cannot be rendered, reduce useless code calculations

BeichenDream added 2 commits July 2, 2021 01:35

Update JediTerminal.java

103275c

Update TerminalPanel.java

dfa3e06

fix code style

9323270

fix code style

BeichenDream added 2 commits July 2, 2021 19:58

Update TerminalPanel.java

a758c80

Update TerminalPanel.java

3cd231c

fix code style

e7df9c1

fix code style

segrey reviewed Jul 2, 2021

View reviewed changes

Optimal calculation

99db2b4

Optimal calculation of X coordinate algorithm Now it only accounts for 3.6% of the CPU in the entire drawing cycle

BeichenDream commented Jul 2, 2021

View reviewed changes

fix bug

dd6eb93

Fix the pull-up progress bar cannot be rendered, reduce useless code calculations

BeichenDream mentioned this pull request May 6, 2022

Chinese support bug #242

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support non-monospace/monospace font rendering #207

Support non-monospace/monospace font rendering #207

BeichenDream commented Jul 1, 2021

BeichenDream commented Jul 1, 2021

segrey commented Jul 2, 2021

BeichenDream commented Jul 2, 2021

segrey commented Jul 2, 2021

BeichenDream commented Jul 2, 2021

segrey commented Jul 2, 2021

BeichenDream commented Jul 2, 2021

segrey Jul 2, 2021

BeichenDream Jul 2, 2021 •

edited

Loading

segrey Jul 2, 2021

BeichenDream Jul 2, 2021 •

edited

Loading

segrey Jul 2, 2021

segrey Jul 2, 2021

BeichenDream Jul 2, 2021

segrey Jul 2, 2021

BeichenDream Jul 2, 2021

BeichenDream Jul 2, 2021

segrey commented Jul 2, 2021

BeichenDream commented Jul 2, 2021

BeichenDream commented Jul 2, 2021

segrey commented Jul 2, 2021

BeichenDream left a comment

BeichenDream Jul 2, 2021

BeichenDream Jul 2, 2021

segrey commented Jul 2, 2021

BeichenDream commented Jul 2, 2021

BeichenDream commented Jul 2, 2021

BeichenDream commented Jul 3, 2021

Support non-monospace/monospace font rendering #207

Are you sure you want to change the base?

Support non-monospace/monospace font rendering #207

Conversation

BeichenDream commented Jul 1, 2021

BeichenDream commented Jul 1, 2021

segrey commented Jul 2, 2021

BeichenDream commented Jul 2, 2021

segrey commented Jul 2, 2021

BeichenDream commented Jul 2, 2021

segrey commented Jul 2, 2021

BeichenDream commented Jul 2, 2021

Choose a reason for hiding this comment

BeichenDream Jul 2, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BeichenDream Jul 2, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

segrey commented Jul 2, 2021

BeichenDream commented Jul 2, 2021

BeichenDream commented Jul 2, 2021

segrey commented Jul 2, 2021

BeichenDream left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

segrey commented Jul 2, 2021

BeichenDream commented Jul 2, 2021

BeichenDream commented Jul 2, 2021

BeichenDream commented Jul 3, 2021

BeichenDream Jul 2, 2021 •

edited

Loading

BeichenDream Jul 2, 2021 •

edited

Loading