This repository has been archived by the owner on Aug 10, 2021. It is now read-only.
https://github.com/JetBrains/kotlin-native/pull/3538 followup. #3547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build.gradle
Outdated
| @@ -356,7 +356,8 @@ task distDef(type: Copy) { | |||
| destinationDir distDir | |||
|
|
|||
| from(project("platformLibs").file("src/platform")) { | |||
| into('klib/platformDef') | |||
| into('konan/platformDef') | |||
| exclude '**/*.sh' | |||
There was a problem hiding this comment.
Why not include '**/*.def' instead?
| @@ -461,6 +462,7 @@ task crossDist { | |||
| } | |||
|
|
|||
| task bundle(type: (isWindows()) ? Zip : Tar) { | |||
| dependsOn("distDef") | |||
There was a problem hiding this comment.
This is likely required for both bundle and bundleRestricted.
SvyatoslavScherbina
approved these changes
Nov 7, 2019
| @@ -83,6 +83,7 @@ private fun generatePlatformLibraries(target: String, inputDirectory: File, outp | |||
| if (!saveTemps) { | |||
| File("$outputDirectory/build-${def.name}").deleteRecursively() | |||
| } | |||
| File("$outputDirectory/clangModulesCache").deleteRecursively() | |||
There was a problem hiding this comment.
The idea behind module cache here was to reuse it for all platform libraries.
There was a problem hiding this comment.
Yeah, moved removal below, PTAL.
olonho
force-pushed
the
generator_followup
branch
from
e35a133 to
0877faf
Compare
SvyatoslavScherbina
approved these changes
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.