Common StringBuilder #3593
Common StringBuilder #3593
Conversation
|
The base branch for this PR will be changed to |
| * @throws IndexOutOfBoundsException or [IllegalArgumentException] when [start] or [end] is out of range of the [csq] character sequence indices or when `start > end`. | ||
| * @throws IndexOutOfBoundsException if [index] is less than zero or greater than the length of this string builder. | ||
| */ | ||
| @Deprecated("Renamed to `insertRange`", ReplaceWith("insertRange(indexm csq, start, end)"), DeprecationLevel.WARNING) |
There was a problem hiding this comment.
It seems too soon to deprecate the existing members in favor of experimental API.
So we should either remove deprecation here, or remove experimentality on those replacements.
There was a problem hiding this comment.
Also a typo in replacement.
| @Deprecated("Renamed to `insertRange`", ReplaceWith("insertRange(indexm csq, start, end)"), DeprecationLevel.WARNING) | |
| @Deprecated("Renamed to `insertRange`", ReplaceWith("insertRange(index, csq, start, end)"), DeprecationLevel.WARNING) |
There was a problem hiding this comment.
No. There are no insert benchmarks for StringBuilder. Do you suppose the additional function invocation introduced tangible performance overhead?
There was a problem hiding this comment.
StringBuilder is very performance sensitive, we need to ensure that there's no regressions here.
There was a problem hiding this comment.
I did benchmark StringBuilder methods, there are no regressions there.
|
Hm, but why all tests/builds fail? |
|
@olonho It's intended to be merged into However, it doesn't pass either. @qurbonzoda Could you rebase your changes onto the latest master and kotlin-mirror/master, where the composite build is apparently green? |
qurbonzoda
force-pushed
the
rr/stdlib/common-string-builder
branch
2 times, most recently
from
f8a23f2 to
90ae0ba
Compare
qurbonzoda
force-pushed
the
rr/stdlib/common-string-builder
branch
from
dc2dec5 to
c4e62e1
Compare
No description provided.