"Replace 'invoke' with direct call" intention: fix false positive whe…

…n function is not operator

#KT-37977 Fixed

idea/src/org/jetbrains/kotlin/idea/intentions/conventionNameCalls/ReplaceInvokeIntention.kt

@@ -8,20 +8,26 @@ package org.jetbrains.kotlin.idea.intentions.conventionNameCalls
 import com.intellij.codeInsight.intention.HighPriorityAction
 import com.intellij.openapi.editor.Editor
 import com.intellij.openapi.util.TextRange
+import org.jetbrains.kotlin.descriptors.FunctionDescriptor
 import org.jetbrains.kotlin.idea.KotlinBundle
 import org.jetbrains.kotlin.idea.intentions.SelfTargetingRangeIntention
 import org.jetbrains.kotlin.idea.intentions.callExpression
 import org.jetbrains.kotlin.idea.intentions.calleeName
+import org.jetbrains.kotlin.idea.intentions.toResolvedCall
 import org.jetbrains.kotlin.psi.KtCallExpression
 import org.jetbrains.kotlin.psi.KtDotQualifiedExpression
+import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
 import org.jetbrains.kotlin.util.OperatorNameConventions
 
 class ReplaceInvokeIntention : SelfTargetingRangeIntention<KtDotQualifiedExpression>(
     KtDotQualifiedExpression::class.java,
     KotlinBundle.lazyMessage("replace.invoke.with.direct.call")
 ), HighPriorityAction {
     override fun applicabilityRange(element: KtDotQualifiedExpression): TextRange? {
-        if (element.calleeName != OperatorNameConventions.INVOKE.asString() || element.callExpression?.typeArgumentList != null) return null
+        if (element.calleeName != OperatorNameConventions.INVOKE.asString() ||
+            element.callExpression?.typeArgumentList != null ||
+            (element.toResolvedCall(BodyResolveMode.PARTIAL)?.resultingDescriptor as? FunctionDescriptor)?.isOperator != true
+        ) return null
         return element.callExpression?.calleeExpression?.textRange
     }
 

idea/testData/intentions/conventionNameCalls/replaceInvoke/java.1.java

@@ -0,0 +1,3 @@
+public class JavaClass {
+    void invoke() {}
+}

idea/testData/intentions/conventionNameCalls/replaceInvoke/java.1.java.after

@@ -0,0 +1,3 @@
+public class JavaClass {
+    void invoke() {}
+}

idea/testData/intentions/conventionNameCalls/replaceInvoke/java.kt

@@ -0,0 +1,3 @@
+fun main() {
+    JavaClass().<caret>invoke()
+}

idea/testData/intentions/conventionNameCalls/replaceInvoke/java.kt.after

@@ -0,0 +1,3 @@
+fun main() {
+    JavaClass()()
+}

idea/testData/intentions/conventionNameCalls/replaceInvoke/notOperator.kt

@@ -0,0 +1,8 @@
+// IS_APPLICABLE: false
+class C {
+    fun invoke() {}
+}
+
+fun main() {
+    C().<caret>invoke()
+}