Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix thread limit #152

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Fix thread limit #152

merged 1 commit into from
Jan 17, 2019

Conversation

bemasc
Copy link
Contributor

@bemasc bemasc commented Jan 17, 2019 •
edited
Loading

It turns out that Sockslib was effectively imposing a limit of 100
open sockets, which is not appropriate for this application. This
change removes the limit.

Fixes #90 and #48 (indirectly, by removing long query delays)

Fix thread limit
95f8668 
It turns out that Sockslib was effectively imposing a limit of 100
open sockets, which is not appropriate for this application.  This
change removes the limit.

Fixes #94 and #48 (indirectly, by removing long query delays)
@bemasc bemasc requested review from alalamav and dalyk January 17, 2019 18:57
@bemasc bemasc mentioned this pull request Jan 17, 2019
Closed
dalyk
dalyk approved these changes Jan 17, 2019
View reviewed changes
Copy link

@dalyk dalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bemasc bemasc merged commit 735e9ef into master Jan 17, 2019
This was referenced Jan 17, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalyk dalyk dalyk approved these changes

@alalamav alalamav Awaiting requested review from alalamav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bemasc @dalyk