Set Default simplify to False in qubo_to_ising
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default value of
simplifytoFalsein thequbo_to_isingto prevent index mismatches between QUBO and Ising models caused by simplification.Changes
Modified the default value of
simplifyparameter inqubo_to_isingfromTruetoFalse.This change helps avoid index mismatches that occur when simplifying the Ising model, which can lead to incorrect results when using var_map.
Note
This is a quick fix.
A more comprehensive solution is needed to ensure correct indexing even when
simplify=True. This will be addressed in a future update.Related Issue
#66