Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding graph_partitioning_tutorial #81

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Conversation

bluest93
Copy link
Contributor

@bluest93 bluest93 commented Oct 8, 2024

Change

Added a notebook of the graph partitioning tutorial

Description

  1. Created a notebook on the usage Qamomile library to solve the graph partitioning problem
  2. Created a folder to save the figures used in the notebook above
  3. Updated the index.md and _toc.yml to include this new tutorial page

Copy link
Contributor

@yuyamashiro yuyamashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the following three change requests and let me know when you've made the changes.

Use plot_quantum_circuit provided by qamomile

Ex.

from qamomile.core.circuit.drawer import plot_quantum_circuit
plot_quantum_circuit(qaoa_circuit)

Once you draw a quantum circuit at the Qamomile layer, you don't need to display the same quantum circuit in both Qiskit and Quri-parts.

Change the Title

The title of the first h1 tag in the notebook will also be used as the heading for the tutorial. The current title, "What is the graph partitioning problem?", is confusing.

"The graph partitioning problem with QAOA" might be a good title. Please think of a good title.

Differences in experimental conditions between Qiskit and Quri-Parts

If there is no reason, please use the same experimental conditions. Readers may be confused by such minor differences.

Or, please clearly explain the reason for the different experimental conditions, such as "Quri-Parts with Qulacs is faster than Qiskit, so we can increase the number of iterations, so let's increase it and try an experiment."

@bluest93
Copy link
Contributor Author

@yuyamashiro Just made three change requests, please take a look! About the title, I changed as similar as Graph Coloring Problem tutorial.

@yuyamashiro yuyamashiro self-requested a review October 10, 2024 08:46
@yuyamashiro yuyamashiro merged commit a01044e into main Oct 10, 2024
6 checks passed
@yuyamashiro yuyamashiro deleted the Tutorial/graph_partitioning branch October 10, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants