Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support QuTiP's Hamiltonian #97

Merged
merged 8 commits into from
Nov 19, 2024
Merged

Support QuTiP's Hamiltonian #97

merged 8 commits into from
Nov 19, 2024
+152 −2

Conversation

bluest93
Copy link
Contributor

Change

Make a new transpiler to support QuTiP's Hamiltonian

Description

  1. Created a qutip directory inside qamomile
  2. Created transpiler.py, exception.py and __inti__.py under qutip directory
  3. Created a qutip directory inside tests
  4. Created test_qutip_transpiler.py under qutip directory

@bluest93 bluest93 marked this pull request as ready for review October 25, 2024 04:10
@bluest93 bluest93 requested a review from Jacomichi October 25, 2024 04:10
@Jacomichi Jacomichi requested a review from yuyamashiro October 25, 2024 07:27
Jacomichi
Jacomichi requested changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@Jacomichi Jacomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left the comment

tests/qutip/test_qutip_transpiler.py Outdated Show resolved Hide resolved
@Jacomichi Jacomichi self-requested a review November 6, 2024 02:13
Jacomichi
Jacomichi requested changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@Jacomichi Jacomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the comment about the error raise.

qamomile/qutip/transpiler.py Outdated Show resolved Hide resolved
qamomile/qutip/transpiler.py Outdated Show resolved Hide resolved
@Jacomichi Jacomichi self-requested a review November 13, 2024 02:41
Jacomichi
Jacomichi requested changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@Jacomichi Jacomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left the comment.

qamomile/qutip/transpiler.py Show resolved Hide resolved
@Jacomichi Jacomichi self-requested a review November 19, 2024 00:20
Jacomichi
Jacomichi approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@Jacomichi Jacomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuyamashiro yuyamashiro merged commit 76e03f1 into main Nov 19, 2024
6 checks passed
@yuyamashiro yuyamashiro deleted the Feature/qutip_transpile branch November 19, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuyamashiro yuyamashiro yuyamashiro approved these changes

@Jacomichi Jacomichi Jacomichi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluest93 @yuyamashiro @Jacomichi