-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Improvments for getter
#137
base: main
Are you sure you want to change the base?
Conversation
BTW, I believe |
Thank you for contributions. It takes some time to take a review this PR, but please consider the following:
|
Thank you for taking time to review my code :)
Yes, I will do that. And the all
I think #70 want to collect all fields' docs and generate them into class document. While in this PR, I only want the field's doc, which seems more basic and useful. #[gen_stub_pyclass]
#[pyclass]
#[gen_stub(attribute_doc)]
struct A {
...
} Or turn on attributes docs for default, and use |
For #133, if you are willing I can fix that in this PR as well. Here is what I consider: |
Hi,
As the conversation here.
This PR contains following updates. Since I introduce
#[gen_stub(xxx)]
attribute, I will update the document/readme when those APIs are stabilized.1. add
indexmap
feature2. propagate getter's documents to class member, e.g.,
or
will get the output:
3. support
#[gen_stub(default=xx)]
User specified default value for getter's class member, e.g.,
or
Output:
4. support
#[gen_stub(skip)]
User specified, ignore a function in
#[pymethods]
, e.g.,Output: