Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable pyo3_stub_gen::derive #17

Merged
merged 5 commits into from
Aug 2, 2024
Merged

Conversation

termoshtt
Copy link
Member

@termoshtt termoshtt commented Aug 2, 2024

Reverts #15 with modified Cargo.toml setting.

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#the-role-of-the-version-key

Note: crates.io does not allow packages to be published with dependencies on code published outside of crates.io itself (dev-dependencies are ignored).

So the problem is dev-dependency.pyo3-stub-gen in pyo3-stub-gen-derive/Cargo.toml specifies version 0.1.0, which did not exists on crates.io. This version specification is not needed, and removed in this PR.

Then, we do not have cyclic dependency. We can release pyo3-stub-gen-derive first, and then pyo3-stub-gen.

@termoshtt termoshtt self-assigned this Aug 2, 2024
@termoshtt termoshtt changed the title derive feature Re-enable pyo3_stub_gen::derive Aug 2, 2024
@termoshtt termoshtt marked this pull request as ready for review August 2, 2024 05:07
@termoshtt termoshtt merged commit 11f5070 into main Aug 2, 2024
9 checks passed
@termoshtt termoshtt deleted the re-enable-derive-feature branch August 2, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant