Elements are lost from arrays of arrays #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a GEDCOM contains arrays of arrays of elements, then the lowest layer elements are lost from the JSON.
This can be demonstrated with:
Expected:
Actual:
Notice the
TEXT
andREFN
elements are lost.The problem occurs in
result.ts
because only the lowest level of an array is considered when settings all sub-objects and buildingpartPath
to get the existing values.The fix is to correctly set
partPath
to include which element in an array to try to get.