Add java code sample for tests #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amoghrajesh
commented
Oct 4, 2022
amoghrajesh
commented
- Added a java file with some code logic
- Updated the tests in analyzer and scanner
|
@JoaoDanielRufino can you help with a review? I think a UT is failing btw. Not sure why though |
|
@JoaoDanielRufino i have refactored the code a bit because the tests were doing an index wise comparison which is not the best style and is not extendable too. I have done some refactoring around that end |
JoaoDanielRufino
requested changes
Oct 4, 2022
Co-authored-by: João Daniel Rufino <[email protected]>
JoaoDanielRufino
requested changes
Oct 5, 2022
Co-authored-by: João Daniel Rufino <[email protected]>
JoaoDanielRufino
requested changes
Oct 5, 2022
pkg/scanner/scanner_test.go
Outdated
Comment on lines
47
to
50
| Lines: 20, | ||
| CodeLines: 15, | ||
| BlankLines: 4, | ||
| Comments: 4, |
There was a problem hiding this comment.
The expected values are incorrect, please run the test and verify if the suggested value is correct
Suggested change
| Lines: 20, | |
| CodeLines: 15, | |
| BlankLines: 4, | |
| Comments: 4, | |
| Lines: 24, | |
| CodeLines: 15, | |
| BlankLines: 5, | |
| Comments: 4, |
There was a problem hiding this comment.
Ah good catch. Had missed it due to rebasing
JoaoDanielRufino
approved these changes
Oct 5, 2022
JoaoDanielRufino
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.