Skip to content

Commit

Permalink
Add more test method in Filter::AlwaysFalse class (facebookincubator#…
Browse files Browse the repository at this point in the history
…9718)

Summary:
We now use alwaysFalse of Filter.h and some method not implemented causing runtime error. So, we'd like to implment some alwaysFalse method to avoid the error.

Pull Request resolved: facebookincubator#9718

Reviewed By: Yuhta

Differential Revision: D57072475

Pulled By: bikramSingh91

fbshipit-source-id: a8986387f044cdf6f21096d06c5fdfc070aba09a
  • Loading branch information
zjuwangg authored and Joe-Abraham committed Jun 7, 2024
1 parent 1c83cd1 commit ca4be99
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions velox/type/Filter.h
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,10 @@ class AlwaysFalse final : public Filter {
return false;
}

bool testNull() const final {
return false;
}

bool testInt64(int64_t /* unused */) const final {
return false;
}
Expand All @@ -321,10 +325,19 @@ class AlwaysFalse final : public Filter {
return false;
}

bool testInt128(int128_t /* unused */) const final {
return false;
}

bool testDouble(double /* unused */) const final {
return false;
}

bool testDoubleRange(double /*min*/, double /*max*/, bool /*hasNull*/)
const final {
return false;
}

bool testFloat(float /* unused */) const final {
return false;
}
Expand Down

0 comments on commit ca4be99

Please sign in to comment.