add check for if MAX_RANGE is NaN

JoeScho · Feb 10, 2021 · e2512a1 · e2512a1
1 parent 1ae6d4e
commit e2512a1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/index.test.ts b/index.test.ts
@@ -103,4 +103,11 @@ describe('for two IP addresses', () => {
     const throwFn = () => getIPRange('128.0.0.0/1');
     expect(throwFn).toThrow('Too many IPs in range. Total number: 2147483647. Max count is 5000, to increase, set the limit with the MAX_RANGE environment variable');
   });
+
+  it('should throw if process.env.MAX_RANGE is NaN', () => {
+    process.env.MAX_RANGE = 'foo';
+
+    const throwFn = () => getIPRange('128.0.0.0/1');
+    expect(throwFn).toThrow('MAX_RANGE must be an integer');
+  });
 });
diff --git a/index.ts b/index.ts
@@ -58,6 +58,9 @@ const isCIDR = (ipCIDR: Address4 | Address6): boolean => Boolean(ipCIDR.parsedSu
 const isRange = (ipRange: string): boolean => ipRange.indexOf('-') !== -1;
 
 const getIPRange = (ip1: string, ip2?: string): Array<string> => {
+  if (process.env.MAX_RANGE && isNaN(parseInt(process.env.MAX_RANGE))) {
+    throw new Error('MAX_RANGE must be an integer');
+  }
   maxRange = parseInt(process.env.MAX_RANGE || '10000');
 
   const ip1v4 = getIPv4(ip1);