Release v1.0 #34
Merged
Release v1.0 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joel-Dahne
force-pushed
the
v1-release
branch
from
d400661 to
739d1a3
Compare
See https://discourse.julialang.org/t/type-instability-because-of-threads-boxing-variables/78395 In short, using Threads.@threads introduces an implicit closure and this causes issues with type stability if a binding is assigned to multiple times. Introducing an explicit let scope fixes these type stability issues.
Joel-Dahne
force-pushed
the
v1-release
branch
from
739d1a3 to
4cfbeee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.