Fix retain cycle in UserSuggestionViewModel

Steps to reproduce: - Launch app - Enter and leave a bunch of rooms - Fire up the memory graph debugger - Filter for `UserSuggestionViewModel` Relates to: element-hq#5058 Signed-off-by: Johannes Marbach <[email protected]>
Johennes · Mar 18, 2022 · 40650cb · 40650cb
1 parent c3b231b
commit 40650cb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/RiotSwiftUI/Modules/Room/UserSuggestion/UserSuggestionViewModel.swift b/RiotSwiftUI/Modules/Room/UserSuggestion/UserSuggestionViewModel.swift
@@ -46,8 +46,8 @@ class UserSuggestionViewModel: UserSuggestionViewModelType, UserSuggestionViewMo
 
         super.init(initialViewState: UserSuggestionViewState(items: items))
 
-        userSuggestionService.items.sink { items in
-            self.state.items = items.map({ item in
+        userSuggestionService.items.sink { [weak self] items in
+            self?.state.items = items.map({ item in
                 UserSuggestionViewStateItem(id: item.userId, avatar: item, displayName: item.displayName)
             })
         }.store(in: &cancellables)

diff --git a/changelog.d/5058.bugfix b/changelog.d/5058.bugfix
@@ -0,0 +1 @@
+UserSuggestionViewModel: Fix retain cycle