Added support for matching parentheses in link URLs #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2022
|
@nicked I'm very sorry for not reviewing this PR, and thanks a lot for contributing. I'm now finally able to get back into reviewing Ink PRs, and ultimately chose to accept @Richard-Gist's implementation for fixing the parenthesis issue in PR #73. So will close this one. Again, my sincere apologies for the lack of feedback on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markdown should support inline links that contain matching pairs of parentheses, eg
[my link](http://example.com/link_(with_parens)). These are quite common on Wikipedia for example.The current implementation is not ideal because of the limitations of Reader, maybe it would be better to add support in there for escaped or balanced pairs of characters?
Also don't like the
.filter.countbut it seemsSubstringdoesn't supportcount(where:)