Recognize CR-LF pairs as newlines for the purposes of Paragraph separation. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DOS CRLF sequence does not pass its test without more code.
Keep in mind that "\r\n" is a single Character as far as Swift is concerned, so this looks a little weird if you were expecting CR and LF to come in as separate characters. Possibly consider redoing the logic on the line to test nextCharacter.isNewLine apart from the nextCharacter.isAny test to catch the other control character and Unicode oddities which count as newlines, since the outer "if" statement is also using that test.
JohnSundell
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Sorry for taking so long to review this PR, @jimstudt, and thanks a lot for fixing this issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the source text is using DOS style CRLF newlines they will not be recognized as paragraph separators when a blank line is built from them. This is a common occurrence if you wish to accept input from web browsers.
This adds a ridiculously tiny code change to recognize the CRLF newline variant and contains a couple tests for verifying both regular LF-LF and CRLF-CRLF paragraph delimiters.
I didn't find any definitive statement on what Markdown accepts as newlines, but given the generally loose definition it seems reasonable to permit this.