Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting of indented lists #62

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

adam-fowler
Copy link
Contributor

When parsing a list which is indented the parser needs to take into account the indentation of the first element otherwise it will it consider subsequent elements to be part of another list internal to the original list ie previously

  - first
  - second
  - third

produces HTML

<ul><li>One<ul><li>Two</li><li>Three</li></ul></li></ul>

With this fix it now produces

<ul><li>One</li><li>Two</li><li>Three</li></ul>

@bdrelling
Copy link

bdrelling commented Sep 12, 2022

I don't understand why this pull request is still pending two years later, unacknowledged. Has this project been abandoned?

It's even worse when it's a piece of functionality the README claims the library can do.

Nested lists are supported as well, by indenting any part of a list that should be nested within its parent.

@adam-fowler
Copy link
Contributor Author

I haven't received comment on any of my Ink PRs so I've kinda of given up on them.

Copy link
Owner

@JohnSundell JohnSundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another excellent fix that should have been merged in a long time ago. So sorry about that @adam-fowler! Thanks a lot for fixing this issue.

@JohnSundell JohnSundell merged commit fb342e1 into JohnSundell:master Apr 7, 2023
@adam-fowler adam-fowler deleted the indented-lists branch April 7, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants