Podcast feed generator episode image feature #119
Conversation
Updating my fork
… longer limited to being the same as the site title.
…JohnSundell-master # Conflicts: # Tests/PublishTests/Tests/PodcastFeedGenerationTests.swift
There was a problem hiding this comment.
Very nice, thanks a lot @Goosse (and sorry for taking so long to provide any feedback on this!). I just made a few stylistic changes to the code, and will merge once CI passes 👍
|
@Goosse Could you perhaps merge the latest |
|
Looks like the merge fixed the CI issues |
| @@ -107,7 +110,7 @@ private extension PodcastFeedGenerator { | |||
| .summary(item.description), | |||
| .explicit(metadata?.isExplicit ?? false), | |||
| .duration(audioDuration), | |||
| .image(config.imageURL), | |||
| .image(imageURL ?? config.imageURL), | |||
There was a problem hiding this comment.
Wouldn't it be better to exclude the image tag altogether when the item has no specific image?
As far as I've been able to tell, all clients will fall back to the main <itunes:image> at the channel level when the episode has no custom artwork. For shows with lots of episodes, having these duplicate tags in the feed add up and make the feed larger than it needs to be.
This pull request adds the functionality of using an item's imagePath to include an image unique to that episode in the RSS feed.