Make decode function const #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnabell
force-pushed
the
const-decode
branch
from
6eb6f7a to
91fe7be
Compare
Johnabell
commented
Sep 5, 2023
| impl From<u8> for Register { | ||
| fn from(value: u8) -> Register { | ||
| impl Register { | ||
| pub(crate) const fn const_from(value: u8) -> Register { |
There was a problem hiding this comment.
Looking forward to not having to do this when this lands: rust-lang/rust#67792
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the instruction decode function
const. Therefore this can be evaluated at compile time for optomization purposes.