Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proxy colonies M3] feat: simple payments on proxy chains #329

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

bassgeta
Copy link
Contributor

@bassgeta bassgeta commented Feb 3, 2025

@bassgeta bassgeta force-pushed the feat/4189-simple-payment-proxies branch from 1f238b4 to 0aecdd6 Compare February 4, 2025 10:14
@bassgeta bassgeta marked this pull request as ready for review February 4, 2025 14:57
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as part of JoinColony/colonyCDapp#4207

Very nice work1

@rdig rdig requested a review from a team February 4, 2025 22:01
Copy link
Contributor

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work @bassgeta 🥇

Tested as part of the CDapp PR

@@ -29,6 +29,7 @@ import { NotificationCategory } from '~types/notifications';
import { verbose } from '@joincolony/utils';

export default async (event: ContractEvent): Promise<void> => {
console.log('ma kaj mamo move funds', event);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this can be removed 👀

@@ -50,6 +50,7 @@ export const mapLogToContractEvent = async (
timestamp,
};
} catch (error) {
console.log('parsing error', error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this? 👀

@bassgeta bassgeta force-pushed the feat/4189-simple-payment-proxies branch from 0aecdd6 to 73e7514 Compare February 5, 2025 10:49
Copy link
Contributor

@davecreaser davecreaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, all looks good, and tested as part of the CDapp PR. ✅

@bassgeta bassgeta merged commit 268cc52 into feat/M3-proxy-colonies Feb 6, 2025
1 check passed
@bassgeta bassgeta deleted the feat/4189-simple-payment-proxies branch February 6, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants