-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proxy colonies M3] feat: simple payments on proxy chains #329
[Proxy colonies M3] feat: simple payments on proxy chains #329
Conversation
1f238b4
to
0aecdd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested as part of JoinColony/colonyCDapp#4207
Very nice work1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -29,6 +29,7 @@ import { NotificationCategory } from '~types/notifications'; | |||
import { verbose } from '@joincolony/utils'; | |||
|
|||
export default async (event: ContractEvent): Promise<void> => { | |||
console.log('ma kaj mamo move funds', event); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably this can be removed 👀
apps/main-chain/src/utils/events.ts
Outdated
@@ -50,6 +50,7 @@ export const mapLogToContractEvent = async ( | |||
timestamp, | |||
}; | |||
} catch (error) { | |||
console.log('parsing error', error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this? 👀
0aecdd6
to
73e7514
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff, all looks good, and tested as part of the CDapp PR. ✅
CDapp PR