Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Payments]Pending button stuck after claiming motion on the Finalize step/ or Claim button appears twice #3859

Closed
olgapod opened this issue Dec 6, 2024 · 3 comments · Fixed by #4056
Assignees
Labels
bug Something isn't working Priority: P1 (High)

Comments

@olgapod
Copy link
Contributor

olgapod commented Dec 6, 2024

Steps to reproduce

  1. Enable reputation extention.
  2. Make sure user has enough tokens and reputation for voting .
  3. Initiate a Move Funds action with Reputation. (Or other actions with the finalize step)
  4. Go through the staking and support process for the motion.
  5. Claim the motion during the Finalize step.
  6. Observe that the "Pending" button remains stuck, even after the motion is claimed. Or sometimes is is shown twice after claming.

Expected behaviour

  • The "Pending" button should update to reflect the completion of the motion claim and transition to a success or finalized state.

Actual behaviour

  • The button remains in the "Pending" state, giving the impression that the process is not complete.
image
@olgapod olgapod added the bug Something isn't working label Dec 6, 2024
@melyndav
Copy link

melyndav commented Dec 6, 2024

@olgapod nice pick up. There's also no padding between the content and the button. It should be 24px. Might need to raise this as a separate issue.

@olgapod
Copy link
Contributor Author

olgapod commented Dec 6, 2024

@melyndav Thanks, added an issue

@melyndav
Copy link

melyndav commented Dec 6, 2024

Thanks @olgapod! 🙌

@rumzledz rumzledz self-assigned this Dec 9, 2024
@olgapod olgapod changed the title [Payments]Pending button stuck after claiming motion on the Finalize step [Payments]Pending button stuck after claiming motion on the Finalize step/ or Claim button appears twice Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: P1 (High)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants