Fix: Automatically propagate user permission updates

[rumzledz]

Description

Note

Please note that there is an existing issue where the Permissions table on the Completed Action form is not correctly showing the permissions that were removed from the user after a Reputation or Multi-Sig motion has successfully been supported/approved and finalised. This is kind of a complex issue and it will not be addressed on this PR.

There is also an existing issue with reputation motions where the Finalise button has the possibility of getting stuck in a Pending state: #3859. You may or may not come across it but just know that this PR has nothing to do with it.

This PR makes use of subscriptions to automatically refresh member permissions information whenever it's updated.

Out of scope yet relevant and manageable fixes: You should also now be able to see the permissions that are marked for removal on the Completed Action component. BUT please note that this fix is only limited to actions done via Permissions as well as with motions that have not been successfully supported/approved and finalised. Please bear this in mind during testing 🙏

Lastly, I did a wee refactor for setting the user data in our AppContextProvider.

Testing

Note

Make sure that Fry doesn't not have any permissions to begin with

Important

• Please do not reload the page in between steps
• Uninstall the Reputation and Multi-Sig extensions

1. Open an incognito window
2. Connect Fry's wallet
3. Bring up the Simple Payment form
4. Verify that you see this error banner:

5. In the non-incognito window, connect Leela's wallet
6. Bring up the Manage Permissions form
7. Give Fry Payer permissions in General
8. Click the incognito window and verify that the error banner has disappeared
9. Click the Decision Method field and verify that you see Permissions in the options list
10. Click the non-incognito window
11. Remove Fry's permissions from General
12. Click the incognito window
13. Verify that you see the error banner again:

New stuff ✨

• Added a new util removeObjectFields which allows you to remove a set of fields from a given object. It's strictly typed so you should be able to see auto-completed fields as you're selecting them:

Resolves #3635

[rdig]

Error banner correctly changes state based on the updated permissions.

Note that I've not refreshed either page in between any of the actions

[mmioana]

Really nice work on this one @rumzledz 💯

Please note no page has been refreshed while following the testing steps 🫡

Started off only with leela having permissions

Tried creating a Simple payment as fry - the error banner is shown

Gave fry Payer permissions in General

The error banner was no longer shown on fry's Simple payment

The Permissions decision method was available

Removed fry's permissions 😢

And back to the error banner for fry

Awesome 🎉

The only reason I'm rejecting this @rumzledz is due to the fact something got wrongly generated for the graphql types, causing the expenditureId and expenditureFunding to be removed from the ColonyMultiSig, so please try running codegen again 🙌

[mmioana]

@rumzledz please try running codegen again, as we shouldn't be removing the expenditureFunding and expenditureId for the ColonyMultiSig model

[rumzledz]

Apologies for this @mmioana , I'm not sure what happened. I just ran it and it generated these for me 😓 But I shall generate it again 👌

[rumzledz]

All right pushed! 🚀 @mmioana

[iamsamgibbs]

Nice job, this works very nicely!

Before:

Screen.Recording.2024-12-12.at.10.09.19.mov

[rdig]

Re-approving. Good to go still

[mmioana]

Still working as expected @rumzledz ✨

Good to go! 🚢