Get user transactions from database instead of redux state #2127
Conversation
chmanie
force-pushed
the
feat/apollo-tx
branch
4 times, most recently
from
def62f7 to
e3828c1
Compare
chmanie
force-pushed
the
feat/apollo-tx
branch
8 times, most recently
from
c1c1e6c to
b5c10e2
Compare
chmanie
force-pushed
the
feat/apollo-tx
branch
3 times, most recently
from
831dcdd to
c423c1a
Compare
There was a problem hiding this comment.
Great effort went into this PR, nice work @chmanie!
I spotted a potential regression when a tx fails:
- on
master, it expands the error details:
Screen.Recording.2024-05-10.at.13.52.05.mov
- whereas on this branch it doesn't happen:
Screen.Recording.2024-05-10.at.13.55.52.mov
Thanks for the review @jakubcolony! I'll take care of it asap. |
chmanie
force-pushed
the
feat/apollo-tx
branch
2 times, most recently
from
cb7404e to
3e6762f
Compare
|
@jakubcolony can you take another look maybe? Thank you! |
There was a problem hiding this comment.
Nice job Chris! Completed pill issue is resolved:
Screen.Recording.2024-07-29.at.09.25.48.mov
I have found one issue, but it might also exist on master.
I created a mint tokens action, but rejected the first transaction. I then retried it from the userhub, this time accepting the transaction, but the "Claim pending transactions" part never triggered. This left the "Pending 1/2" pill spinning forever, even after a refresh, and there is no way to retry it from the userhub.
|
Just tested this on master - it does behave the same, except the "pending" pill disappears after a refresh. I think the change here to show the "pending" pill after a refresh makes sense as there are still pending transactions, but I wouldn't be surprised if we find more stuck "pending" pills in other areas of the app. |
|
Oh yeah that's definitely something that needs to be fixed but can't be in the current state. As a matter of fact, the transaction API refactor that I'm working on will fix this issue. |
Description
Sorry for another big one :(
This PR moves the transaction state to Apollo, from redux. It does not remove sagas but it enables a path forward to refactor this gradually. All sagas should still work, except that the transaction state is read from the Apollo cache / the database as opposed to redux.
Redux as a whole also wasn't removed yet, as some of the sagas depend on other parts of the state, still (like gas prices estimation). This can be done in a follow-up PR.
Another thing that isn't in scope is the fix of the transactions list paging (didn't work before), for that I'm going to open yet another PR.
I used optimistic UI updates for the transaction updates so that changes should be reflected as fast as before.
Testing
Basically everything should work as before. Please create some transactions and/or bigger transaction groups to test this.
Diffs
Changes 🏗
Deletions ⚰️
Resolves #2171