Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Token Actions if Not Available #2326

Merged
merged 1 commit into from
May 7, 2024

Conversation

rdig
Copy link
Member

@rdig rdig commented May 6, 2024

Intro Note

This PR is part of the set that will be opened by me to (re)introduce all the changes made to support the Arbitrum deployment, from the master-arbitrum branch back into master so that the two branches can be (more or less) identical

We need to run two branches, since AWS enforces one deployment per branch, meaning we can't run both the Gnosis and Arbitrum deployment from the same branch.

This will get cleaned up, once we get to Multichain and we will be back to only supporting one main deployment (which itself will support multiple networks, whatever form this might take)

Current PR Details

This PR adds some checks to disable the "Mint Token" and "Unlock Token" actions if the colony doesn't have permissions to do so. This usually happens when you are using an external token, not one created by you, when creating the colony.

Testing

Testing this is quite easy, just create a new colony, but instead of creating a new token along side it, just bring one from an existing colony (planex for example).

  • The actions to unlock and mind should be grayed out in your action selector
  • The "mint" option in the Balance page's kebab menu should not be visible
  • The "mint tokens" link should not be visible in the "third menu"

Screenshot from 2024-04-08 13-18-13

Resolves #2163

@rdig rdig self-assigned this May 6, 2024
@rdig rdig requested review from a team as code owners May 6, 2024 09:53
Copy link
Contributor

@ArmandoGraterol ArmandoGraterol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected 👍

Screenshot 2024-05-06 at 16 29 57

Not related to this PR I think but I found this bug clicking the Transfer Funds item on the finances page:

Screenshot 2024-05-06 at 16 29 40

Reproducible through this menu:

Screenshot 2024-05-06 at 16 33 01

Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me! Tested and working as expected.

Screenshot 2024-05-07 at 10 14 07 Screenshot 2024-05-07 at 10 15 45 Screenshot 2024-05-07 at 10 22 23

@rdig rdig force-pushed the maintenance/disable-token-actions branch from 225fece to 9ee4de3 Compare May 7, 2024 11:36
@rdig rdig merged commit b6c9d9f into master May 7, 2024
3 checks passed
@rdig rdig deleted the maintenance/disable-token-actions branch May 7, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide "Mint tokens" action when using existing token
3 participants