fix: Unable to open settings menu on mobile when action sidebar is open #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Nortsova
commented
Jun 18, 2024
| <PillsBase | ||
| className="bg-success-100 text-success-400" | ||
| isCapitalized={false} | ||
| <div className="relative"> |
There was a problem hiding this comment.
here is not that much changes, only added this div with relative class. I desided create a new div because when I added it to line below header border was hidden under opened settings menu
iamsamgibbs
approved these changes
Jun 18, 2024
rdig
approved these changes
Jun 18, 2024
| <PillsBase | ||
| className="bg-success-100 text-success-400" | ||
| isCapitalized={false} | ||
| <div className="relative"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed opening settings in action sidebar. The problem was that the settings had top:
100% !important, which helped position it under the header. However, in the case of the action sidebar, the "relative"-fixed value was higher on the wrapper with the header plus action form, so the settings screen was positioned down, under the action form.Position: relative on the correct div fixed that.
Testing
Resolves #2548