Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: show the correct team members count when a team filter is applied on the Dasbhoard #2571

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fix: show the correct team members count when a team filter is applied on the Dasbhoard #2571

merged 1 commit into from
Jul 1, 2024

Conversation

rumzledz
Copy link
Contributor

@rumzledz rumzledz commented Jun 18, 2024 •
edited
Loading

Description

2502

Testing

  1. Create a new team
  2. Go to the Dashboard
  3. Filter the view by the team you just made
  4. Keep track of the Members count
  5. Click on the Members widget
  6. Verify that the number of members you see corresponds to the number shown on the Members widget from the Dashboard

Diffs

Changes 🏗

  • Updated the members array being used to show the number of members per team on the Dashboard

Resolves #2502

@rumzledz rumzledz self-assigned this Jun 18, 2024
@rumzledz rumzledz requested review from a team as code owners June 18, 2024 15:49
@rumzledz rumzledz force-pushed the fix/2502-show-correct-members-on-dashboard branch from 9a814d3 to 92c91d9 Compare June 19, 2024 05:40
melyndav
melyndav approved these changes Jun 19, 2024
View reviewed changes
Copy link

@melyndav melyndav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ayyyyy @rumzledz nice work on this one! Thanks for the fix 🤙

jakubcolony
jakubcolony approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@jakubcolony jakubcolony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, well done navigating the MemberContext maze!

master:

Screen.Recording.2024-06-19.at.21.40.10.mov

This branch:

Screen.Recording.2024-06-19.at.21.41.46.mov

iamsamgibbs
iamsamgibbs approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Fix makes sense 👍 Strange that it was using allMembers before!

Screen.Recording.2024-06-27.at.11.25.00.mov

@rumzledz rumzledz merged commit 8c57f50 into master Jul 1, 2024
4 of 6 checks passed
@rumzledz rumzledz deleted the fix/2502-show-correct-members-on-dashboard branch July 1, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamsamgibbs iamsamgibbs iamsamgibbs approved these changes

@melyndav melyndav melyndav approved these changes

@jakubcolony jakubcolony jakubcolony approved these changes

Assignees

@rumzledz rumzledz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Members dashboard widget showing wrong value
4 participants
@rumzledz @iamsamgibbs @melyndav @jakubcolony