Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CreatedIn Field should be read only for Move Funds motions #2684

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

davecreaser
Copy link
Contributor

Description

  • Set the createdIn field to read only, and fix it as root, when making a motion of type Move Funds.
  • Right now, only General (the root domain) should be allowed to be used when making this type of motion, since no other domain will work. The created in domain must be a parent domain of both the To and the From domains.

Testing

  • Install the reputation weighted extension (then refresh the page).
  • Create a new action, and select Transfer Funds as the action type, and Reputation as the decision method.
  • Try to change the created in field. You should not be able to, and it should be General.
Screenshot 2024-07-09 at 17 16 03

Diffs

Changes 🏗

  • Set the createdIn field to read only, and fix it as root, when making a motion of type Move Funds.

Resolves #2683

@davecreaser davecreaser requested review from a team as code owners July 9, 2024 16:16
@davecreaser davecreaser self-assigned this Jul 9, 2024
@mmioana mmioana self-requested a review July 10, 2024 09:25
Copy link
Contributor

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @davecreaser

When creating a Transfer funds action and selection the Reputation decision method, the Created In field shows and is not editable
screen-capture.webm

Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with this Dave, can confirm Transfer Funds motion can only be created in general.

Screenshot 2024-07-10 at 13 44 40

Copy link
Contributor

@bassgeta bassgeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Nice one, can't click on the little bugger anymore 🚢

Copy link

@melyndav melyndav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, johhny dapp @davecreaser! Nice update and works as expected. 🚶

@davecreaser davecreaser merged commit 8184bb1 into master Jul 10, 2024
4 of 6 checks passed
@davecreaser davecreaser deleted the fix/#2683-move-funds-createdin-field branch July 10, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User should not be able to set createdIn when making a Move Funds motion
5 participants