fix: update list paddings, load all stakes regardless of colonies, update redirect to stakes #2759

Nortsova · 2024-07-23T18:32:34Z

Description

Padding of items in the list should match the design.
The items in the list should not overflow the container.
The pills should show the correct status.
The list of claimable motions should be visible across all colonies

Testing

Ensure that Reputation is installed

Step 1. Create actions with reputation decision method, title should be long

Step 2. Stake this motion
Step 3. Go to UserHub

Step 4. Create different motions on different stages (Claimable, Claimed, Finalizable, Pending)

Ensure that styles are correct here
Step 5. Go to another Colony (wayne) and open UserHub

Ensure that even tho Reputation extension is not installed, you can see stakes from all colonies
Step 6. Enable Reputation Extension for Wayne colony
Step 7. Create new Staking motion in Wayne colony
Step 8. Check UserHub to see all motions

Step 9. Click to motion from different colony and see that you will be redirected
Step 10. Uninstall Reputation Extension and go to UserHub (update: now Uninstalled became "Lost" status)

(Full uninstalled functionality done in #2737)
Step 11. Create stakes, uninstall VotingReputation. Install it again. All not claimed stakes should have status "Lost".

Step 12. Create motions in different colonies and finalize them. You will see "Claimable" status

Step 13. Press the "Claim all" button and ensure that motions in both colonies claimed.

Step 14. Create motion and during pending and processing - open UserHub/Stakes tab

It shouldn't blink. (Sam found this bug in this review - #2759 (review))

Step 15. Disconnect and connect wallet. Open UserHub - stakes should have correct statuses, not "Lost"

Diffs

New stuff ✨

Bug fixed:
After Step 8 click on motion from other colonies.
It was a bug with tx param, it was removed and the user was redirected to the colony page instead of motion page. Now it open the correct link

Resolves #2566

CLAassistant · 2024-07-23T18:32:39Z

All committers have signed the CLA.

rdig · 2024-07-24T20:34:34Z

Is this ready for review?

Nortsova · 2024-07-25T12:07:16Z

Is this ready for review?

No, it is in progress.

Nortsova · 2024-07-26T08:35:33Z

src/hooks/useNetworkMotionStatesAllColonies.ts

@@ -0,0 +1,189 @@
+import {


I would really appreciate for review this file and any comments are welcome, it kinda duplication for https://github.com/JoinColony/colonyCDapp/blob/master/src/hooks/useNetworkMotionStates.ts
But I tried to do it for all user colonies, not only for the current one

Good shout with a separate hook for all colonies. I think it can be simplified a bit further to roughly follow this flow:

Get all installed extensions for joined colonies

Select all voting reputation addresses (directly from the query data, you shouldn't need any mapping)

Get network states for each of the motions

Create a map between motion database IDs and states so that a flat map can be used

iamsamgibbs

Nice start to this issue, it is definitely more complicated than it initially appeared! I think the estimate should definitely go up from 4 hours.

All the UI fixes look great, looking much tidier now!

I did notice the "Claim all stakes" button does not appear on mobile - not sure if this is intended?

There are a few issues I've noticed.

The stake amount should show using the native token for the colony it was created in. Currently it uses the token for the colony you have open.

Switching to the correct colony is working nicely, great job with that!

Screen.Recording.2024-07-26.at.11.35.07.mov

There is no loading spinner when you first open the userhub after a refresh:

Screen.Recording.2024-07-26.at.12.05.33.mov

This is particularly noticeable on a slower connection - it also initially loads in with the wrong status:

Screen.Recording.2024-07-26.at.12.12.05.mov

There is also this issue when opening the userhub straight after staking a motion. I think this only happens during the few seconds directly after staking a motion so this might not be a big deal and we could address it separately.

Screen.Recording.2024-07-26.at.12.08.16.mov

After uninstalling the extension, all stakes are shown as "uninstalled". I think for the stakes we know have already been claimed, we should still show those as "claimed" rather than setting it as "uninstalled". I personally think "uninstalled" should be shown as "lost" for the stakes that we know were unclaimed when the extension was uninstalled - but this might need checking with @arrenv

After re-installing the extension, new motions created with the new extension are seemingly using the same nativeId (or whatever is being called to check the status), as the old stakes (from the now uninstalled extension) are also being updated.

In this screenshot the bottom one is from the now uninstalled extension, the top one is from the newly installed extension.

If you have unclaimed stakes across multiple colonies, then the "claim all stakes" button only works for the current colony you are in. It would be great to make this claim stakes across all colonies, or if this isn't possible it should be reworded "Claim all stakes in this colony" or something. The state also doesn't update until the userhub is closed and reopened.

Screen.Recording.2024-07-26.at.12.16.34.mov

Thank you for tackling this complicated issue though! It highlights some of the issues we may have when we make the userhub accessible outside of colonies which will be required as part of the crypto to fiat work.

iamsamgibbs · 2024-07-26T10:43:16Z

src/components/common/Extensions/UserHub/partials/StakesTab/helpers.ts

-  if (!motionState) {
-    return UserStakeStatus.Unknown;
+  const colonyAddress = stake.action?.colonyAddress;
+  const currentColonyMotionState = statesMap?.get(colonyAddress ?? '');


Doesn't need a ? after statesMap here

iamsamgibbs · 2024-07-26T10:45:13Z

src/components/common/Extensions/UserHub/partials/StakesTab/helpers.ts

+  const reputationAddress =
+    colonyAddress && votingReputationByColony[colonyAddress];


Think this variable could have a better name

src/components/v5/common/ActionSidebar/ActionSidebar.tsx

iamsamgibbs · 2024-07-26T10:52:36Z

src/components/common/Extensions/UserHub/partials/StakesTab/partials/StakeItem.tsx

+  const stakeColonyName = stake.action?.colony.name ?? '';
+
+  useEffect(() => {
+    if (colonyName !== stakeColonyName) {


Can we compare colonyAddresses here? It is possible for two colonies to have the same name so this is a bad comparison.

jakubcolony

Very nice effort with this pretty complex issue @Nortsova

Reducing nesting of the mapping between colony addresses and motions and their states would help improve the overall readability. I think this could be achieved if you can instead create a map between database motion ID (it's unique across colonies and formatted as chainId-votingRepExtnAddress_nativeMotionId) and their corresponding states.

Please ensure you type the arguments of the functions you add as it reduces the risk of mistakes.

jakubcolony · 2024-07-29T22:53:35Z

src/components/common/Extensions/UserHub/partials/StakesTab/StakesTab.tsx

@@ -53,7 +56,7 @@ const StakesTab = () => {
    >
      <div className="mb-4 flex items-center justify-between sm:px-6 sm:pt-6">
        <p className="heading-5">{formatMessage({ id: 'stakes' })}</p>
-        {!isMobile && (
+        {!isMobile && votingReputationAddress && (


What is the purpose of this check? It prevents staked expenditure stakes from being claimed if voting rep is not installed

jakubcolony · 2024-07-29T23:05:17Z

src/graphql/queries/extensions.graphql

@@ -15,3 +15,39 @@ query GetExtensionInstallationsCount($id: ID!) {
    reputationWeighted
  }
 }
+
+query GetAllColoniesExtensions(


Perhaps GetJoinedColoniesExtensions would better describe what it does?

jakubcolony · 2024-07-29T23:07:40Z

src/graphql/queries/extensions.graphql

+  $sortDirection: ModelSortDirection = ASC
+  $limit: Int = 100
+  $nextToken: String
+  $isWatching: Boolean


It feels like this argument doesn't belong here anymore, should the query always set the filter to true instead?

jakubcolony · 2024-07-29T23:10:27Z

src/hooks/useNetworkMotionStatesAllColonies.ts

+const getInstalledExtensions = (colony, versionsData) => {
+  const colonyExtensions = colony?.extensions?.items?.filter(notNull);
+  if (!colonyExtensions) {
+    return [];
+  }
+
+  const extensionVersions =
+    versionsData?.listCurrentVersions?.items?.filter(notNull);
+
+  const colonyExtensionsMap = colonyExtensions.map((extension) => {
+    const extensionConfig = supportedExtensionsConfig.find(
+      (e) => getExtensionHash(e.extensionId) === extension?.hash,
+    );
+
+    const { version } =
+      extensionVersions?.find((e) => e?.extensionHash === extension.hash) || {};
+
+    // Unsupported extension
+    if (!extensionConfig || !version) {
+      return null;
+    }
+
+    return mapToInstalledExtensionData({
+      colony,
+      extensionConfig,
+      colonyExtension: extension,
+      version,
+    });
+  });
+  return colonyExtensionsMap.filter(notNull);
+};
+
+const getVotingReputationAdress = (installedExtensions): string | undefined => {
+  const votingReputationExtension = installedExtensions.find(
+    (extension) => extension.extensionId === Extension.VotingReputation,
+  );
+
+  return votingReputationExtension?.address;
+};


Is all this processing necessary if you only care about the hash and the address of each colony extensions?

jakubcolony · 2024-07-29T23:15:41Z

src/hooks/useNetworkMotionStatesAllColonies.ts

@@ -0,0 +1,189 @@
+import {


Good shout with a separate hook for all colonies. I think it can be simplified a bit further to roughly follow this flow:

Get all installed extensions for joined colonies

Select all voting reputation addresses (directly from the query data, you shouldn't need any mapping)

Get network states for each of the motions

Create a map between motion database IDs and states so that a flat map can be used

jakubcolony · 2024-07-29T23:20:12Z

src/hooks/useJoinedColoniesWithExtensions.ts

+const sortByDate = <T extends { createdAt: string }>(a: T, b: T) =>
+  new Date(a.createdAt).getTime() - new Date(b.createdAt).getTime();
+
+const useJoinedColoniesWithExtensions = (userAddress?: string) => {


This hook seems very specific to useNetworkMotionStates, I would either make it a helper or place it next to that hook to indicate it's not intended to be reusable

Nortsova · 2024-08-05T20:25:11Z

I noticed an error that I can't manually repeat. It happen for this request:

const votingRepClient = VotingReputationFactory.connect(
     votingReputationAddress,
     ethersProvider as unknown as Provider,
 );
try {
 const motionState = await votingRepClient.getMotionState(nativeMotionId);
  statesMap.set(nativeMotionId, motionState);
 } catch (e) {
    console.log('error', e);
    statesMap.set(nativeMotionId, null);
 }

I also tried to do it with check if fullWallet but it didn't help

Nortsova · 2024-08-06T09:24:49Z

A scenario for signerOrProvider error found, here is another bug with the same issue - #2643

iamsamgibbs

Really great work on this @Nortsova ! 🎉 This definitely hasn't been an easy issue, so fantastic job on getting this to work so nicely!

Truncation looks good on both desktop and mobile:

The motion pills in the different states as viewed from another colony:

Claiming all with stakes in different colonies works without a hitch. I also tested this from a completely new colony where the extension has never been installed before and was able to claim a stake from another colony via "claim all". 🎉 Nice work adjusting the saga to accommodate the different colony and extension addresses.

Screen.Recording.2024-08-07.at.09.55.39.mov

Statuses show correctly after the extension has been uninstalled and reinstalled, and stakes open the correct transaction when clicked.

I've only found two major issues. The first is if you have no voting reputation extension installed in a colony that has old motions, the stakes will fail to load:

Screen.Recording.2024-08-07.at.09.56.27.mov

Once a new version of the extension is installed, they will load again. (This issue still happens if you switch to another colony where the extension is installed).

There is also this console warning which it would be great if you could look into and resolve. I'm not sure how this could affect other parts of the app if left as is.

I'm guessing it has something to do with how getContributorsByAddress is being used to get all the colony extensions.

iamsamgibbs · 2024-08-07T09:16:15Z

src/redux/types/actions/motion.ts

+        motionIds: {
+          databaseMotionId: string;
+          colonyAddress: string;
+          extensionAddress: string;
+        }[];


I wonder if there is a better name than motionIds now that this is an object

Good catch, @iamsamgibbs ! thanks!

jakubcolony

Thank you for addressing my previous feedback @Nortsova, feels like it's not very far off.

I left a couple of comments, but overall you've done a great job so far. Nice work 💪

jakubcolony · 2024-08-07T21:38:23Z

src/components/common/Extensions/UserHub/partials/StakesTab/partials/ClaimAllButton.tsx

-        motionIds: claimableStakes.map(
-          (stake) => stake.action?.motionData?.databaseMotionId ?? '',
-        ),
+        motionStates: claimableStakes.map((stake) => ({


Should this be called something like userStakes instead? It's not only motions (expenditures can have stakes too)

jakubcolony · 2024-08-07T21:53:22Z

src/context/ActionSidebarContext/ActionSidebarContextProvider.tsx

@@ -84,6 +95,7 @@ const ActionSidebarContextProvider: FC<PropsWithChildren> = ({ children }) => {
  );

  const toggleOff = useCallback(() => {
+    removeTxParamOnClose();
    return toggleActionSidebarOff();
  }, [toggleActionSidebarOff]);


There's a warning from GH build action about missing dependency in this line

src/graphql/fragments/colony.graphql

jakubcolony · 2024-08-07T21:57:40Z

src/graphql/queries/stake.graphql

+  }
+}
+
+query GetUserStakesByColony($userAddress: ID!, $colonyAddress: ID!) {


This isn't used anywhere now, so let's remove it 🗑️

jakubcolony · 2024-08-07T22:02:20Z

src/hooks/useNetworkMotionStatesAllColonies.ts

+
+export type MotionStatesMap = Map<string, MotionState | null>;
+
+export type MotionStatesMapByColonies = Record<string, MotionStatesMap>;


Looks unused

jakubcolony · 2024-08-07T22:15:16Z

src/hooks/useNetworkMotionStatesAllColonies.ts

+  const {
+    joinedColoniesWithExtensions,
+    loading: joinedColoniesWithExtensionsLoading,
+  } = useJoinedColoniesWithExtensions(wallet?.address);
+
+  const votingReputationByColony = useMemo(() => {
+    return joinedColoniesWithExtensions.reduce((prev, colony) => {
+      if (!colony) {
+        return prev;
+      }
+      return {
+        ...prev,
+        [colony.colonyAddress]: getVotingReputationAddressByColony(colony),
+      };
+    }, {});
+  }, [joinedColoniesWithExtensions]);


Maybe moving the useMemo block to the useJoinedColoniesWithExtensions hook would make the body of this hook a bit lighter?

jakubcolony · 2024-08-07T22:17:05Z

src/hooks/useNetworkMotionStatesAllColonies.ts

+      return !motionStatesMap.has(motion.databaseMotionId);
+    });
+    const deletedMotionIds = Array.from(motionStatesMap.keys()).filter(
+      (nativeMotionKey) =>


Please update the naming to indicate if it is the native ID or database ID. It should be database ID as only those are unique between colonies

jakubcolony · 2024-08-07T22:17:26Z

src/hooks/useNetworkMotionStatesAllColonies.ts

+      const statesMap = new Map(motionStatesMap);
+
+      await Promise.all(
+        newMotionIds.map(async (nativeMotion) => {


I'm not sure about nativeMotion, why such name?

jakubcolony · 2024-08-07T22:18:33Z

src/hooks/useNetworkMotionStatesAllColonies.ts

+      deletedMotionIds.forEach((nativeMotionId) =>
+        statesMap.delete(nativeMotionId),
+      );


Please update naming here as well

jakubcolony · 2024-08-07T22:44:42Z

src/components/common/Extensions/UserHub/partials/StakesTab/partials/StakeItem.tsx

+    useGetFullColonyByAddressQuery({
+      variables: {
+        address: stake.action?.colonyAddress || '',
+      },
+      fetchPolicy: 'network-only',
+      nextFetchPolicy: 'cache-first',
+    });


It's an expensive query to be making for each stake in the list, I think the best thing to do here would be to modify the UserStake model to include a reference to colony field. You can then extract just the native token and its decimals in one go.

You could go a step further if you wish and fetch the extensions in the UserStake fragment as well. The benefit of such approach is that it would also work for stakes in colonies that the user has subsequently left.

iamsamgibbs

Thanks for fixing the issues I raised! I've not seen the console warning and the code fixes for that make sense.

I've also tested the stake loading when there is no extension installed which is working now!

Screen.Recording.2024-08-08.at.09.12.37.mov

Once you've fixed up the comments Jakub has left I'll drop an approval on this.

Unrelated to this PR, but the activity feed will need a similar fix to what you have done here as it tries to load the old motion data through the new extension:

Screen.Recording.2024-08-08.at.09.15.16.mov

It also doesn't support the new "Lost" pill and will just show "Unknown" so we'll need to update this at a later point.

Nortsova · 2024-08-08T14:17:03Z

Thank you @iamsamgibbs! This is a really important note. I created a ticket for Activity Feed - #2907

iamsamgibbs

Nice work on this! The code refactor makes sense. I've retested everything and all is still working! 👍

iamsamgibbs · 2024-08-09T12:38:59Z

src/components/common/Extensions/UserHub/partials/StakesTab/partials/StakeItem.tsx

+      nativeToken: {
+        decimals: stake.action?.colony.nativeToken.nativeTokenDecimals,
+        symbol: stake.action?.colony.nativeToken.nativeTokenSymbol,
+        tokenAddress: stake.action?.colony.nativeToken.tokenAddress,
+        name: stake.action?.colony.nativeToken.name,
+      },


Could this just be nativeToken: state.action?.colony.nativeToken?

jakubcolony

A lot of effort went into this PR so kudos to you @Nortsova.

I can see my stakes from across all colonies and navigate between them:

Screen.Recording.2024-08-13.at.16.18.04.mov

After uninstalling voting rep, the status shows as Lost:

Finalizable and claimable statuses also work fine:

I left a couple of comments but they're nothing major, so thumbs up from me 👍 Very nice work 💯

jakubcolony · 2024-08-13T07:16:52Z

src/components/common/Extensions/UserHub/partials/StakesTab/partials/StakeItem.tsx

      <button
        type="button"
        onClick={() =>
          navigate(
-            `${window.location.pathname}?${TX_SEARCH_PARAM}=${stake.action?.transactionHash}`,
+            setQueryParamOnUrl(
+              navigatePath,


Do we need a state for this or can we just use stakeColonyName here? Would make it a bit simpler to read without the state and useEffect

jakubcolony · 2024-08-13T07:19:23Z

src/hooks/useNetworkMotionStates.ts

@@ -7,6 +7,7 @@ import { useAppContext } from '~context/AppContext/AppContext.ts';
 import useEnabledExtensions from './useEnabledExtensions.ts';

 export type MotionStatesMap = Map<string, MotionState | null>;
+export type VotingReputationByColonyId = Record<string, string>;


nit-picking, Id should be Address instead to avoid confusion

jakubcolony · 2024-08-13T07:38:20Z

src/hooks/useNetworkMotionStatesAllColonies.ts

+  const currentExtensionAddress = colonyExtensions.find((extension) => {
+    const extensionConfig = supportedExtensionsConfig.find(
+      (e) => getExtensionHash(e?.extensionId) === extension?.hash,
+    );
+    return extensionConfig?.extensionId === Extension.VotingReputation;
+  });
+  return currentExtensionAddress?.address;


Suggested change

const currentExtensionAddress = colonyExtensions.find((extension) => {

const extensionConfig = supportedExtensionsConfig.find(

(e) => getExtensionHash(e?.extensionId) === extension?.hash,

);

return extensionConfig?.extensionId === Extension.VotingReputation;

});

return currentExtensionAddress?.address;

const votingRepExtension = colonyExtensions.find(

(extension) =>

extension.hash === getExtensionHash(Extension.VotingReputation),

);

return votingRepExtension?.address;

getExtensionHash can be imported from colony-js

jakubcolony · 2024-08-13T07:39:33Z

src/hooks/useNetworkMotionStatesAllColonies.ts

+
+/**
+ * Hook that accepts an array of UserMotionStake and returns a map of motion IDs to their states
+ * Make sure to memoize the array of motion IDs to avoid infinite loops


This comment seems no longer relevant

rdig

Tested and everything works as expected, at least the part that you fixed in this PR. Very good work Anastasiia! 💯

I did found something however, but something that's not really a issue related to this PR.

While a very long (multiple words) title shows up correctly, a title that contains a non-breakable word (no spaces) will break both the actions list UI as well as the action sidebar

I do want to note however, that it shows correctly in the Userhub where you fixed it in this PR

… it close related functions

…oring for checking url

…r on voting reputation connection

…ning

…R review

mmioana

Wow, really impressive work @Nortsova 🥇 Thank you for tackling this issue 🤩

Went through the testing steps and can confirm the required changes are in place

Screen.Recording.2024-08-14.at.10.27.33.mov

Screen.Recording.2024-08-14.at.10.34.36.mov

However, I noticed claiming all stakes was not possible from the User Hub 😢
Can you please check?

Screen.Recording.2024-08-14.at.10.35.49.mov

mmioana

There was an issue with my env, can confirm also the claiming all stakes is working

Screen.Recording.2024-08-14.at.14.32.15.mov

rdig

Working as expected after your changes. Re-tested and everything is there. Nicely done!

Nortsova requested review from a team as code owners July 23, 2024 18:32

Nortsova marked this pull request as draft July 23, 2024 18:32

Nortsova changed the title ~~fix: update list paddings, load all stakes regardless of colonies, update redirect to stakes~~ [WIP] fix: update list paddings, load all stakes regardless of colonies, update redirect to stakes Jul 23, 2024

bassgeta force-pushed the feat/multi-sig branch from 74f0e58 to f2b4b8f Compare July 25, 2024 13:13

Nortsova force-pushed the fix/2566-user-hub-stakes branch from a8934cf to 7ab3f3b Compare July 26, 2024 08:33

Nortsova changed the base branch from feat/multi-sig to master July 26, 2024 08:33

Nortsova marked this pull request as ready for review July 26, 2024 08:33

Nortsova changed the title ~~[WIP] fix: update list paddings, load all stakes regardless of colonies, update redirect to stakes~~ fix: update list paddings, load all stakes regardless of colonies, update redirect to stakes Jul 26, 2024

Nortsova commented Jul 26, 2024

View reviewed changes

iamsamgibbs requested changes Jul 26, 2024

View reviewed changes

Nortsova self-assigned this Jul 26, 2024

jakubcolony requested changes Jul 29, 2024

View reviewed changes

Nortsova force-pushed the fix/2566-user-hub-stakes branch from d5c1654 to 7710c45 Compare August 6, 2024 12:19

Nortsova requested review from jakubcolony and iamsamgibbs August 6, 2024 14:35

iamsamgibbs requested changes Aug 7, 2024

View reviewed changes

Nortsova force-pushed the fix/2566-user-hub-stakes branch from a1eb500 to 45a6745 Compare August 7, 2024 17:07

Nortsova requested a review from iamsamgibbs August 7, 2024 17:08

jakubcolony requested changes Aug 7, 2024

View reviewed changes

iamsamgibbs requested changes Aug 8, 2024

View reviewed changes

Nortsova mentioned this pull request Aug 8, 2024

[Activity feed]: Should show status "Lost" for stakes if Voting Reputation deleted #2907

Closed

Nortsova requested review from jakubcolony and iamsamgibbs August 8, 2024 14:16

iamsamgibbs previously approved these changes Aug 9, 2024

View reviewed changes

jakubcolony previously approved these changes Aug 13, 2024

View reviewed changes

rdig previously approved these changes Aug 13, 2024

View reviewed changes

Nortsova and others added 14 commits August 14, 2024 09:47

fix: update UserHub styles, show all stakes in user hub, fix statuses

c4df6f1

fix: fix bugs and issues according to PR review

6414203

fix: refactor useNetworkMotion for All colonies, making Map flat

e88f67a

fix: replaced uninstalled status with lost

88a407d

feat: make 'Claim all stakes' worked for stakes from all colonies

11ba629

fix: show lost status for stakes with previous voting reputation address

67b7928

fix: refactor get installed extensions

75d7b11

fix: move useJoinedColoniesWithExtension to useNetworkMotionStates as…

7e5b8d8

… it close related functions

fix: move types for MotionId and VotingReputationObject, small refact…

31b88a0

…oring for checking url

fix: update motion key to databaseMotionId format

417e7f5

fix: unknown/lost statuses in some cases, replace provider with signe…

69b873c

…r on voting reputation connection

fix: bug with uninstalled extension, rename motion IDs, fix cache war…

65a055b

…ning

fix: refactor and rename motionIds to userMotionStakes according to P…

c0d7fb5

…R review

fix: refactor get current extension, navigatePath, partialStakeColony

7dd8791

Nortsova dismissed stale reviews from rdig, jakubcolony, and iamsamgibbs via 7dd8791 August 14, 2024 07:48

Nortsova force-pushed the fix/2566-user-hub-stakes branch from 2a11ea5 to 7dd8791 Compare August 14, 2024 07:48

jakubcolony approved these changes Aug 14, 2024

View reviewed changes

mmioana self-requested a review August 14, 2024 08:02

mmioana reviewed Aug 14, 2024

View reviewed changes

mmioana self-requested a review August 14, 2024 12:33

mmioana approved these changes Aug 14, 2024

View reviewed changes

rdig approved these changes Aug 14, 2024

View reviewed changes

Nortsova merged commit c470f5f into master Aug 15, 2024
3 of 6 checks passed

Nortsova deleted the fix/2566-user-hub-stakes branch August 15, 2024 08:34

		const reputationAddress =
		colonyAddress && votingReputationByColony[colonyAddress];


		export type MotionStatesMap = Map<string, MotionState \| null>;

		export type MotionStatesMapByColonies = Record<string, MotionStatesMap>;

fix: update list paddings, load all stakes regardless of colonies, update redirect to stakes #2759

fix: update list paddings, load all stakes regardless of colonies, update redirect to stakes #2759

Conversation

Nortsova commented Jul 23, 2024 • edited Loading

Description

Testing

Diffs

CLAassistant commented Jul 23, 2024 • edited Loading

rdig commented Jul 24, 2024

Nortsova commented Jul 25, 2024

Nortsova Jul 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamsamgibbs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakubcolony left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nortsova commented Aug 5, 2024

Nortsova commented Aug 6, 2024

iamsamgibbs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakubcolony left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamsamgibbs left a comment

Choose a reason for hiding this comment

Nortsova commented Aug 8, 2024

iamsamgibbs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakubcolony left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rdig left a comment

Choose a reason for hiding this comment

mmioana left a comment

Choose a reason for hiding this comment

mmioana left a comment

Choose a reason for hiding this comment

rdig left a comment

Choose a reason for hiding this comment

Nortsova commented Jul 23, 2024 •

edited

Loading

CLAassistant commented Jul 23, 2024 •

edited

Loading

Nortsova Jul 26, 2024 •

edited

Loading