-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crypto-to-fiat: Payments to liquidation address should show relevant member #2892
Crypto-to-fiat: Payments to liquidation address should show relevant member #2892
Conversation
createLiquidationAddress, | ||
{ | ||
input: { | ||
chainId: 42161, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be made into an env variable once they're set up in lambdas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff @jakubcolony ! I connected Dev Wallet 1 and it correctly detects that it's Leela's liquidation address ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c36a424
into
feat/2793-liquidation-address
Description
This PR fixes a number of issues around displaying the relevant user whose liquidation address a payment was made to.
When payment is made to the liquidation address, it should be swapped with relevant user in the following places:
Testing
Unless you're testing against Bridge production, there's no way to test this properly as the sandbox generated addresses are not valid ETH addresses.
For that reason, we'll create a liquidation address in the DB manually. In production, this will be done by the
checkKyc
handler whenever it finds that a user doesn't have an address linked to their bank account already.Make simple and advanced payments to the created liquidation address. In each of the places listed above, it should be replaced with your user's details.
Screen.Recording.2024-08-08.at.09.23.31.mov
Screen.Recording.2024-08-08.at.09.25.00.mov
Note: The recipient field's user popover will show the address twice instead of the username, it's an existing issue tracked by #2891.
Resolves #2733