Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Remove Colony Objective widget and remove functionality to manage Colony objectives #2942

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

rumzledz
Copy link
Contributor

@rumzledz rumzledz commented Aug 13, 2024

Description

remove-col-objectives

Testing

Important

Check out to another branch and create a Manage Objective action then come back to this branch once that's done.

Testing steps

  1. Please verify that you are no longer able to view the Colony Objectives widget from:
  • Dashboard: /{colony}
  • Colony Details page: /{colonyName}/details
  1. Verify that the Manage Colony Objectives option is not present in the Action Sidebar's Action type field
  2. Go to your Dashboard
  3. Observe the Latest activity table
  4. Verify that the copy for "Manage objective by {user}" is still in tact
  5. Filter the activity table using the Colony Objective Action type
  6. Verify that the Colony Objective Actions are correctly being filtered
  7. Click this Colony Objective Action
  8. Verify that the Completed Action form comes up and shows you the details for the Manage objective action
  9. On the Completed Action form, verify that the copy for "Manage objective by {user}" is still in tact
  10. Open the UserHub and go to the Transactions Tab
  11. Verify that you can still see the Edit Colony Details and the copy is in tact
  12. Click Edit Colony Details
  13. Verify that the Completed Action form comes up and shows you the details for the Manage objective action

Resolves #2797

@rumzledz rumzledz self-assigned this Aug 13, 2024
@rumzledz rumzledz marked this pull request as ready for review August 13, 2024 16:25
@rumzledz rumzledz requested review from a team as code owners August 13, 2024 16:25
@rumzledz rumzledz changed the title Maintenance: Remove colony objective widget and remove Edit Colony action from the Action Sidebar Maintenance: Remove colony objective widget and remove Manage Objective action from the Action Sidebar Aug 13, 2024
@rumzledz rumzledz marked this pull request as draft August 13, 2024 19:32
@rumzledz rumzledz force-pushed the maintenance/2797-remove-colony-objective branch from 91b07c5 to 2344b79 Compare August 13, 2024 19:55
@rumzledz rumzledz changed the title Maintenance: Remove colony objective widget and remove Manage Objective action from the Action Sidebar Maintenance: Remove Colony Objective widget and remove Manage Objectives action from the Action Sidebar Aug 13, 2024
@rumzledz rumzledz marked this pull request as ready for review August 13, 2024 19:57
@rumzledz rumzledz marked this pull request as draft August 13, 2024 20:08
@rumzledz rumzledz force-pushed the maintenance/2797-remove-colony-objective branch from 2344b79 to 41215fc Compare August 13, 2024 20:08
@rumzledz rumzledz marked this pull request as ready for review August 13, 2024 20:18
@rumzledz rumzledz force-pushed the maintenance/2797-remove-colony-objective branch 2 times, most recently from ad8a9cf to 0baacb5 Compare August 14, 2024 16:30
@rumzledz rumzledz force-pushed the maintenance/2797-remove-colony-objective branch from 0baacb5 to ccc2fed Compare August 14, 2024 16:35
@rumzledz rumzledz changed the title Maintenance: Remove Colony Objective widget and remove Manage Objectives action from the Action Sidebar Maintenance: Remove Colony Objective widget and remove functionality to manage Colony objectives Aug 14, 2024
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a code review only, and seems all fine.

However this has yet to remove the ColonyObjective type, it's relationship to ColonyMetadata, as well as the graphql fragment.

I will do a functional review once those have been removed.

@rumzledz
Copy link
Contributor Author

rumzledz commented Aug 22, 2024

Hey @rdig thanks for having a look at this. I left those in because if for example, I removed the ColonyObjectives Fragment then the Completed Action component won't be able to show existing Colony Objective actions properly:

image

The issue is that we still need to show existing Colony Objective actions

@rumzledz rumzledz requested review from rdig and a team August 22, 2024 11:25
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct for leaving the Object data in, it was my oversight. Nicely done.

I've tested the UI and everything seems to (not be) showing up, no errors in the console, so I consider this all good.

Screenshot from 2024-08-22 17-48-25
Screenshot from 2024-08-22 17-48-30
Screenshot from 2024-08-22 17-48-40
Screenshot from 2024-08-22 17-48-53
Screenshot from 2024-08-22 17-48-58
Screenshot from 2024-08-22 17-49-31
Screenshot from 2024-08-22 17-50-32

@rumzledz rumzledz requested a review from a team August 22, 2024 22:09
Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, followed all the testing steps without issue!

Master:

Screenshot 2024-08-30 at 11 06 15

This branch:

Screenshot 2024-08-30 at 11 06 32

Master:

Screenshot 2024-08-30 at 11 09 03

This branch:

Screenshot 2024-08-30 at 11 06 52

No longer in the actions list:

Screenshot 2024-08-30 at 11 07 07

Activity feed:

Screenshot 2024-08-30 at 11 23 35

Transaction tab:

Screenshot 2024-08-30 at 11 23 59

Completed action:

Screenshot 2024-08-30 at 11 21 19

Good job!

@rumzledz rumzledz requested a review from a team September 2, 2024 10:26
Copy link
Contributor

@davecreaser davecreaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup @rumzledz, waving goodbye to objectives 👋

Tested via your steps and everything looks correct:
Screenshot 2024-09-02 at 13 41 09
Screenshot 2024-09-02 at 13 43 03
Screenshot 2024-09-02 at 13 43 15
Screenshot 2024-09-02 at 13 43 26
Screenshot 2024-09-02 at 13 43 45
Screenshot 2024-09-02 at 13 44 10
Screenshot 2024-09-02 at 13 44 36
Screenshot 2024-09-02 at 13 45 13

@rumzledz rumzledz merged commit 914ac30 into master Sep 2, 2024
4 of 6 checks passed
@rumzledz rumzledz deleted the maintenance/2797-remove-colony-objective branch September 2, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 'Manage objective' from app
4 participants