-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance: Remove Colony Objective widget and remove functionality to manage Colony objectives #2942
Conversation
91b07c5
to
2344b79
Compare
2344b79
to
41215fc
Compare
ad8a9cf
to
0baacb5
Compare
0baacb5
to
ccc2fed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a code review only, and seems all fine.
However this has yet to remove the ColonyObjective
type, it's relationship to ColonyMetadata
, as well as the graphql fragment.
I will do a functional review once those have been removed.
Hey @rdig thanks for having a look at this. I left those in because if for example, I removed the The issue is that we still need to show existing Colony Objective actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup @rumzledz, waving goodbye to objectives 👋
Description
Testing
Important
Check out to another branch and create a Manage Objective action then come back to this branch once that's done.
Testing steps
/{colony}
/{colonyName}/details
Resolves #2797