Fix: Display user reputation in its non-scientific notation format #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumzledz
changed the title
mmioana
previously approved these changes
Aug 14, 2024
Comment on lines
144
to
147
| decimals={getTokenDecimalsWithFallback( | ||
| colony.nativeToken.decimals, | ||
| DEFAULT_TOKEN_DECIMALS, | ||
| )} |
There was a problem hiding this comment.
Given the getTokenDecimalsWithFallback already uses DEFAULT_TOKEN_DECIMALS as it's fallback value I think we can skip passing it as the 2nd argument
There was a problem hiding this comment.
Oh you're right @mmioana , you know what I'll clean up other places where this is being done as well 👌
There was a problem hiding this comment.
@mmioana pushed! 🚀 I've also cleaned up other areas that use this redundant 2nd argument
…ecimalsWithFallback function
bassgeta
approved these changes
Aug 14, 2024
davecreaser
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Nice fix, nice clean up, nice job @rumzledz! 🧹
Working nicely:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Resolves #2706