-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: update account avatar upload flow #2996
Conversation
6175f9a
to
de747a1
Compare
7f2a40e
to
ff40bab
Compare
cbf1ab3
to
4814f7b
Compare
8efb4e6
to
28c5b66
Compare
28c5b66
to
e475f24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! All looks as expected on desktop:
![Screenshot 2024-08-29 at 08 48 58](https://private-user-images.githubusercontent.com/34915414/362584918-27875ac9-30fb-4a76-b35e-6dcbab6c0978.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTgzOTAsIm5iZiI6MTczOTI1ODA5MCwicGF0aCI6Ii8zNDkxNTQxNC8zNjI1ODQ5MTgtMjc4NzVhYzktMzBmYi00YTc2LWIzNWUtNmRjYmFiNmMwOTc4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA3MTQ1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQyMmZkYjg1ZTJiZWQ5MGU1NGU5YjU5Y2RiMDhhODAxZDRjNGNlMTkyYTkwOWIwNzY4NTRjNWNhNTkxYTEwNzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.F0u2_E-0w-WMOhK4LqEnlHGAHbfTSgiHuuDqRrNfr5A)
![Screenshot 2024-08-29 at 08 49 04](https://private-user-images.githubusercontent.com/34915414/362584925-b71b9a64-62f0-4070-9bdc-b801f692438e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTgzOTAsIm5iZiI6MTczOTI1ODA5MCwicGF0aCI6Ii8zNDkxNTQxNC8zNjI1ODQ5MjUtYjcxYjlhNjQtNjJmMC00MDcwLTliZGMtYjgwMWY2OTI0MzhlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA3MTQ1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFjN2RmM2Q2YmZiMGY5ODViZjJiYmMyMGM5OGQ1NjM4MzBhY2IxZGRlMDc0YmQzYWM4YmYzNGFmZTBmMGNlYjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.7fu5dte_pep3Ee_yE-6Ih9M339hGNTboEA9dxZ8EKn0)
![Screenshot 2024-08-29 at 08 49 30](https://private-user-images.githubusercontent.com/34915414/362584926-136f3e86-80db-4bbc-9fc6-61f41f38f9a6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTgzOTAsIm5iZiI6MTczOTI1ODA5MCwicGF0aCI6Ii8zNDkxNTQxNC8zNjI1ODQ5MjYtMTM2ZjNlODYtODBkYi00YmJjLTlmYzYtNjFmNDFmMzhmOWE2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA3MTQ1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUwZWZkMTc2OGY2ZDQyYWU5MWJjYzUxMGZhMmE5MDYzOTRmMTQ4NjM4Y2MzNmYxMGJjYzlmNDc2OGY1M2VhNGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.5eQXTVEUSwg9DZdpmEpnqm7qbL8crlHe9P1yVZdUUpU)
And on mobile:
![Screenshot 2024-08-29 at 08 52 18](https://private-user-images.githubusercontent.com/34915414/362585049-e3ef9b64-fc50-4cd1-a0d1-ad333a2da27f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTgzOTAsIm5iZiI6MTczOTI1ODA5MCwicGF0aCI6Ii8zNDkxNTQxNC8zNjI1ODUwNDktZTNlZjliNjQtZmM1MC00Y2QxLWEwZDEtYWQzMzNhMmRhMjdmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA3MTQ1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ4M2UxNWYzZTFjZGUwZWJiMWQ2ZTk4OGExZTcwYzI5YmZlM2VmNGI4NzBiNGJhZDhjMmRlMGViNTgxODZmMWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.LWwYq1Dyr_h38iG_-x5djTGAONfAiY4B6hqL4FJTS-0)
![Screenshot 2024-08-29 at 08 52 55](https://private-user-images.githubusercontent.com/34915414/362585054-df4b9d10-9894-415c-8e34-5f0b285e0dec.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTgzOTAsIm5iZiI6MTczOTI1ODA5MCwicGF0aCI6Ii8zNDkxNTQxNC8zNjI1ODUwNTQtZGY0YjlkMTAtOTg5NC00MTVjLThlMzQtNWYwYjI4NWUwZGVjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA3MTQ1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI4YWRlZDc0NGQyZTIzOTdiNGQyMDk0ZjY2NWUxNDA5NGZjMzNlZTBhMmM0MGE1ODcwYzRjNzI5OTczMmRjZWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.UC72WagUGlUOP8dcXqOYDNUmAgWzJNEFIQD6pEs8Jpw)
![Screenshot 2024-08-29 at 08 53 02](https://private-user-images.githubusercontent.com/34915414/362585058-97b6aa90-41e2-40b1-94b0-0dda07c71ae6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTgzOTAsIm5iZiI6MTczOTI1ODA5MCwicGF0aCI6Ii8zNDkxNTQxNC8zNjI1ODUwNTgtOTdiNmFhOTAtNDFlMi00MGIxLTk0YjAtMGRkYTA3YzcxYWU2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA3MTQ1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZkOWU1MjVlYTUwNWM0ODM5NmU1YmQxZDFhZWFjOWZmMjJlM2EzMjgzMTdiZDM2NmFhMTIyYzAyMDIxMzgwNDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.j_St7fQWx3TjEQnkzcU2wOUAeARtbkNXZ_-7sg3U-8g)
Also tested as a user with a brand new profile without issue.
The only thing that might be worth adding (at a later point unless you really want to add it) is a confirmation modal when you click "Remove avatar". Feels a bit too easy to me to accidentally remove your avatar currently.
I like this idea @iamsamgibbs , I'll discuss this with product 👌 |
Description
This PR will conditionally show the avatar upload functionality in the User Account page.
Testing
Resolves #2872