Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update account avatar upload flow #2996

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

rumzledz
Copy link
Contributor

@rumzledz rumzledz commented Aug 23, 2024

Description

This PR will conditionally show the avatar upload functionality in the User Account page.

new

Testing

  1. Visit the User Account page http://localhost:9091/account/profile
  2. You should see the following buttons by default:
  • Change avatar
  • Remove avatar (if an avatar has been uploaded)
    image
  1. Clicking "Change avatar" should reveal our file upload component
  2. Clicking "Remove avatar" should remove the avatar

Resolves #2872

@rumzledz rumzledz self-assigned this Aug 23, 2024
@rumzledz rumzledz force-pushed the fix/2872-user-account-avatar branch 5 times, most recently from 6175f9a to de747a1 Compare August 26, 2024 10:04
@rumzledz rumzledz marked this pull request as ready for review August 26, 2024 10:06
@rumzledz rumzledz requested review from a team as code owners August 26, 2024 10:06
@rumzledz rumzledz force-pushed the fix/2872-user-account-avatar branch 2 times, most recently from 7f2a40e to ff40bab Compare August 26, 2024 10:09
@rumzledz rumzledz marked this pull request as draft August 26, 2024 10:13
@rumzledz rumzledz force-pushed the fix/2872-user-account-avatar branch 2 times, most recently from cbf1ab3 to 4814f7b Compare August 26, 2024 10:56
@rumzledz rumzledz marked this pull request as ready for review August 26, 2024 10:56
@rumzledz rumzledz marked this pull request as draft August 26, 2024 11:13
@rumzledz rumzledz force-pushed the fix/2872-user-account-avatar branch 3 times, most recently from 8efb4e6 to 28c5b66 Compare August 26, 2024 12:49
@rumzledz rumzledz force-pushed the fix/2872-user-account-avatar branch from 28c5b66 to e475f24 Compare August 26, 2024 12:52
@rumzledz rumzledz marked this pull request as ready for review August 26, 2024 12:58
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Works as expected.

Also, thanks for updating the auth proxy back to it's correct version.

Screenshot from 2024-08-27 17-20-59
Screenshot from 2024-08-27 17-21-01
Screenshot from 2024-08-27 17-21-20

Copy link
Contributor

@bassgeta bassgeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look very sensible and best of all, stuff works 😎
image
image
Upon clicking remove:
image
Tablet view:
image

Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! All looks as expected on desktop:

Screenshot 2024-08-29 at 08 48 58 Screenshot 2024-08-29 at 08 49 04 Screenshot 2024-08-29 at 08 49 30

And on mobile:

Screenshot 2024-08-29 at 08 52 18 Screenshot 2024-08-29 at 08 52 55 Screenshot 2024-08-29 at 08 53 02

Also tested as a user with a brand new profile without issue.

The only thing that might be worth adding (at a later point unless you really want to add it) is a confirmation modal when you click "Remove avatar". Feels a bit too easy to me to accidentally remove your avatar currently.

@rumzledz
Copy link
Contributor Author

The only thing that might be worth adding (at a later point unless you really want to add it) is a confirmation modal when you click "Remove avatar". Feels a bit too easy to me to accidentally remove your avatar currently

I like this idea @iamsamgibbs , I'll discuss this with product 👌

@rumzledz rumzledz merged commit 3aed21d into master Aug 29, 2024
4 of 6 checks passed
@rumzledz rumzledz deleted the fix/2872-user-account-avatar branch August 29, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production: User account avatar UI fixes
4 participants