Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update get user query to be 'cache-first' to solve reloading issue #3178

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

Nortsova
Copy link
Contributor

@Nortsova Nortsova commented Sep 26, 2024

Description

Pairprogrammed it with @bassgeta. Thank you for your help :)

Before

blick-before


Now

blick-now

Testing

  1. Ensure you have past activity in our colony.
  2. Ensure your screen is wide enough to see the activity feed and open the action panel.
  3. Open and close the action panel.
  4. Note the activity feed isn't blicking now.

Resolves #2806

@Nortsova Nortsova requested review from a team as code owners September 26, 2024 10:14
@Nortsova
Copy link
Contributor Author

This bug looks like a part of bigger issue: #3179

@Nortsova Nortsova self-assigned this Sep 27, 2024
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Tested and indeed it prevents the activity feed from re-rendering

Before:

Screencast.from.2024-09-27.11-07-02.mp4

After:

Screencast.from.2024-09-27.11-13-20.mp4

Also tested the "full page" activity feed:

Screencast.from.2024-09-27.11-13-45.mp4

Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, this is so much nicer now!

Dashboard:

Screen.Recording.2024-09-27.at.10.16.39.mov

Activity feed:

Screen.Recording.2024-09-27.at.10.16.55.mov

I did notice the motion timers get refreshed when opening the action sidebar, but this isn't a big deal:

Screen.Recording.2024-09-27.at.10.18.25.mov

Copy link
Contributor

@bassgeta bassgeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So simple but so nice! I actually think it's how we should've written this hook in the first place since it's used in SO many places, poor network tab of our users, constantly spamming the BE :P

sidebar-2024-09-27_11.26.35.mp4

@Nortsova Nortsova merged commit e988813 into master Sep 27, 2024
4 of 6 checks passed
@Nortsova Nortsova deleted the fix/2806-activity-feed-loading branch September 27, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity feed loading on action panel opening
4 participants