-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make avatars clickable #3198
Conversation
strzelec seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start on this PR @adam-strzelec 🎉
Everything works as expected, but I would appreciate if you can tackle my comment 🙏
Screen.Recording.2024-09-30.at.09.32.03.mov
<Link | ||
to={{ | ||
pathname: `/${colonyName}/${COLONY_CONTRIBUTORS_ROUTE}`, | ||
search: `${links?.[0]?.to.search}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest refactoring this line, as the links
might update and is not a reliable source of truth for the parameter we want to use
So my suggestion would be to add an extra property to the TeamCardProps
either nativeId
or searchParams
and then update the useTeams
hook to include either the nativeId
or
searchParams: {
team: `${TEAM_SEARCH_PARAM}=${nativeId}`
}
and then use it here either as
search:
?${TEAM_SEARCH_PARAM}=${nativeId},
or
search:
?${searchParams.team},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmioana done 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job on this @adam-strzelec ! Can confirm the avatars are linking to the correct page with the correct team filter. :)
Screen.Recording.2024-09-30.at.10.03.56.mov
However, this part of the original issue has been missed:
The hover state of the icons should show a highlighted border on individual avatars using the primary blue/400 color token.
When the component is hovered, the border on each of the icons should change to blue-400:
Please also address Ioana's code suggestion.
@iamsamgibbs done 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Adam! Can you also add the transition-colors
class so that the border transitions in the same way as the other hover states on the site?
Screen.Recording.2024-09-30.at.11.39.39.mov
Screen.Recording.2024-09-30.at.11.39.51.mov
@iamsamgibbs done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, this looks great now:
Screen.Recording.2024-09-30.at.12.36.24.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your changes and continuous effort @adam-strzelec 🥇
It all looks great now and behaves as expected 🎉
Description
Make avatars on teams page clickable
Testing
/{colony_name}/teams
pageDiffs
New stuff ✨
Add link for avatars inside
TeamCard
componentResolves #31415