Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent display error banner when extension data is loading #3249

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

adam-strzelec
Copy link
Contributor

Description

After open Action Sidebar to create agreement, during fetching extensions data, the no extension error banner is visible even though all required extensions are installed.

Screenshot 2024-10-02 at 14 11 39

Testing

  • Set network connection to eg. 3G
  • Click Create agreement on agreements page
  • Error banner should not be visible when data is fetching

Diffs

Changes 🏗

add checking if data is not loading inside useIsFieldDisabled hook

Resolves #3239

@adam-strzelec adam-strzelec self-assigned this Oct 2, 2024
@adam-strzelec adam-strzelec requested review from a team as code owners October 2, 2024 12:22
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


strzelec seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! This is working as expected.

Screenshot 2024-10-02 at 13 42 48

Tested it both with and without the extension installed.

It does have the reverse effect than the original issue where if you are a user without permissions, the banner will take a split second before it shows up - but I think this is the lesser of two evils and the 'Create agreement' button is still disabled so it is not as if the user could try to create the agreement.

Copy link
Contributor

@bassgeta bassgeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple, the banner shows up when necessary and not immediately, nice one 💯
image

@adam-strzelec adam-strzelec merged commit 2708220 into master Oct 8, 2024
3 of 5 checks passed
@adam-strzelec adam-strzelec deleted the fix/16097785-view-extension-banner branch October 8, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create agreement flashing missing extension error banner
4 participants