fix: replace div with span in SkeletonLoading component for html cons…

[Nortsova]

Description

Before:

Testing

Step 1. Check that there is no errors in the console

Step 2. Check that all Skeletons still shown correctly:

Resolves #3268

[iamsamgibbs]

This looks like a sensible change! Can we do it on master rather than enhanced-dashboard? :)

[rdig]

All good here. I approved it, but as @iamsamgibbs said, please change the base branch and do this change on master, not on the dashboard feature branch

[iamsamgibbs]

All looks good! Let's get it merged into master.

[rumzledz]

I'm not entirely sure if I agree with this fix since the root issue is that FundsCardsSubTitle is written like this:

<p className="flex items-center gap-2">
  <LoadingSkeleton className="h-[27px] w-[90px] rounded" isLoading={isLoading}>
    <span>{value}</span>
  </LoadingSkeleton>

  <LoadingSkeleton isLoading={isLoading} className="h-5 w-[30px] rounded">
    <span className="uppercase text-1">{currency}</span>
  </LoadingSkeleton>
</p>

We could just simply replace p with div, keep the LoadingSkeleton as a div and tadaaa

But at the same time, I don't feel strongly about a component that only momentarily appears and this code update gets rid of the error as well anyway so I'm approving this. Great stuff @Nortsova 💯

The base branch was changed.

[CLAassistant]

All committers have signed the CLA.

[Nortsova]

Thank you all for the review! 🙌 I updated the base branch to master. ✨

Thank you @rumzledz for your comment! I really appreciate it 🙌 I considered that fix, but it really depends on our goal. I decided to implement a universal fix for the future, as I believe there could be other cases where we might want to place a Skeleton inside a <p> tag. While I think this will be a rare scenario, it's still possible.

[iamsamgibbs]

Thanks for the change! Still looking good.

[rdig]

re-approving