Feat: Add new pill for advanced payments #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nortsova
previously approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Nice and simple fix, thank you @iamsamgibbs ✨
By the way, do we have any plans or tickets for "Coming soon" label?
🎉 Not that I know of, but I could see it be needed in the future so thought it best to leave intact. |
jakubcolony
previously approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Nice work on the badge @iamsamgibbs 👍
The issue is a few months old and we've since added split and staged payments, so I'm wondering if they should also get the New label.
|
Oh, you are completely correct, let me check with Mel which actions this should apply to. |
iamsamgibbs
dismissed stale reviews from jakubcolony and Nortsova
via
d8842e2
|
Added the "New" pill to both Split payment and Staged payment too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a "New" pill which appears next to newly added actions in the action select menu to make them stand out.
Testing
Diffs
New stuff ✨
Resolves #2709