Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ManageVerifiedMembers action saga should use correct annotation channel #3329

Merged

Conversation

iamsamgibbs
Copy link
Contributor

Description

This PR fixes an issue with the Manage Verified Members action saga which was preventing actions with descriptions from being created.

Testing

Create a Manage verified members action, make sure you enter a description. It should be created without issue.

Diffs

Changes 🏗

  • Manage Verified Members action saga takes from the correct channel

Resolves #3285

@iamsamgibbs iamsamgibbs self-assigned this Oct 15, 2024
@iamsamgibbs iamsamgibbs marked this pull request as ready for review October 15, 2024 08:29
@iamsamgibbs iamsamgibbs requested review from a team as code owners October 15, 2024 08:29
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as expected. Nicely done!

Screenshot from 2024-10-15 12-56-53
Screenshot from 2024-10-15 12-57-27
Screenshot from 2024-10-15 12-59-56
Screenshot from 2024-10-15 13-00-07

Copy link
Contributor

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a straight-forward fix @iamsamgibbs 👏
Thanks for solving this issue 💯

Screenshot 2024-10-16 at 12 50 25
Screenshot 2024-10-16 at 12 50 44

Copy link
Contributor

@Nortsova Nortsova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and simple fix! Thanks

Motion created without any issues ✨

image

@iamsamgibbs iamsamgibbs merged commit 97417c3 into master Oct 16, 2024
4 of 6 checks passed
@iamsamgibbs iamsamgibbs deleted the fix/3285-unable-to-verify-members-with-description-added branch October 16, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Manage verified members with description added
4 participants