Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: InputBase dark mode background #3355

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: InputBase dark mode background #3355

merged 1 commit into from
Oct 17, 2024

Conversation

Nortsova
Copy link
Contributor

@Nortsova Nortsova commented Oct 16, 2024 •
edited
Loading

Description

Motions "Create new team", "Edit a team" or "Edit colony" have input with white bg in dark mode.

image

Testing

  1. Enable "Dark mode"
  2. Open "Create new team" motion
  3. Ensure that there is no white bg for inputs
image
  1. Check "Edit a team", "Edit colony" as well
  2. Check "Split payments":
image

Resolves #3319

@Nortsova Nortsova requested review from a team as code owners October 16, 2024 12:07
@Nortsova Nortsova self-assigned this Oct 16, 2024
bassgeta
bassgeta approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@bassgeta bassgeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and easy fix 😎
Create new team ✔️
image
Edit team ✔️
image
Manage reputation ✔️
image
Advanced payment ✔️
image
Split payments ✔️

mmioana
mmioana approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @Nortsova 🫶

There are no longer inputs in the action sidebar with a white background 💯

Screenshot 2024-10-17 at 12 12 42
Screenshot 2024-10-17 at 12 13 05
Screenshot 2024-10-17 at 12 13 23
Screenshot 2024-10-17 at 12 13 53
Screenshot 2024-10-17 at 12 13 58

rdig
rdig approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here

Screenshot from 2024-10-17 15-33-48
Screenshot from 2024-10-17 15-34-00
Screenshot from 2024-10-17 15-34-27
Screenshot from 2024-10-17 15-35-02

@Nortsova Nortsova merged commit 6e113c7 into master Oct 17, 2024
4 of 5 checks passed
@Nortsova Nortsova deleted the fix/3319-dark-mode-input-bg branch October 17, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdig rdig rdig approved these changes

@bassgeta bassgeta bassgeta approved these changes

@mmioana mmioana mmioana approved these changes

Assignees

@Nortsova Nortsova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some text input fields have the wrong background colour on dark mode
4 participants
@Nortsova @rdig @bassgeta @mmioana