fix: permissions sidebar margins and cleanup sidebar stuff a bit

[bassgeta]

Description

The entire solution was that the UserPopover was wrapped in a div and that increased the height.
But as I was perusing the code I saw a lot of remnants regarding fetching the action in the form, since we used to reuse the form for that, and I cleaned some of it up.
The ActionSidebarContent never rendered if transactionId was defined, since we showed a loader or the CompletedAction component.

Figma link

Testing

1. Create an action using Permissions and assure that the margins and alignment now matches Figma
2. Verify that creating an advanced payment with Staking as the decision method still works correctly (so that the first modal with the amount and fees opens)
3. If you think of any case you can try that one too

Diffs

Changes 🏗

• Fixed permissions sidebar padding
• PermissionsSidebar now receives the actions as a property since it doesn't ever refetch/poll it

Deletions ⚰️

• ActionSidebarContent doesn't use isMotion and transactionId anymore, also removed the rendering of the sidebar

Resolves #2959

[rdig]

As far as I can test, all good here. Nicely done!

[iamsamgibbs]

Nice job tidying this all up. Matches figma perfectly.

[mmioana]

Awesome work on this one @bassgeta 🎉

All good from my side regarding your fixes

@bassgeta unrelated to your changes I noticed the user pill jumping when opening the popover, not sure whether it is worth tackling here or we already have an issue for this

Screen.Recording.2024-10-24.at.11.35.10.mov

[rdig]

Re-approving

[mmioana]

Awesome work @bassgeta 🎉

Clicking on the user pill no longer makes the row to jump

Screen.Recording.2024-10-25.at.10.45.16.mov

Advanced payment with Staking

All good to merge 👍

[iamsamgibbs]

Looks like there is a merge conflict after the notifications merge, happy to re-review once it is rebased!

[iamsamgibbs]

Still looks great after the rebase

[rdig]

re-approving

[mmioana]

Awesome @bassgeta! Let's merge this one 🚀