Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation mode for checking if colony url exists form #3428

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

bassgeta
Copy link
Contributor

@bassgeta bassgeta commented Oct 22, 2024

Description

I solved this by comparing it to the colony name creation, figuring out that one works and this one doesn't, what's the difference?
Well basically it wasn't a race condition, but it instead "revalidated" when the field changed focus 🫠

Testing

  1. Run the create data script
  2. Run node ./scripts/create-colony-url.js and open the URL
    image
  3. Into the URL field, enter planex and wait for this to appear
    image
  4. Enter something else and URL should be available
    image

Notice how you don't see the URL available flashing into URL already taken behaviour described in the original issue

Diffs

Changes 🏗

  • onChange revalidation mode to the colony name step

Resolves #3309

@bassgeta bassgeta requested review from a team as code owners October 22, 2024 14:02
Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a lovely simple fix. 10 / 10

Screen.Recording.2024-10-22.at.17.03.02.mov

Copy link
Contributor

@rumzledz rumzledz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean fix! ✨

fixxx

Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Screencast.from.2024-10-23.14-07-55.mp4

@bassgeta bassgeta merged commit 397443c into master Oct 23, 2024
4 of 5 checks passed
@bassgeta bassgeta deleted the fix/3309-existing-colony-url branch October 23, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Create Colony Flow]: Incorrect message is shown for a taken URL in the "Custom Colony URL" field
4 participants