Fix: "Upgrade" button on Calmity Banner should be enabled for all users

[iamsamgibbs]

Description

This PR ensures the "Upgrade" button on the Calamity Banner is always enabled for all users when a new colony version is available.

Testing

To save you the hassle of deploying a colony on an older version, we must first update the canColonyBeUpgraded function in src/utils/checks/canColonyBeUpgraded.ts to return true.

• Step 1 - Connect to a colony as a user with root permissions. Confirm the Calamity Banner is visible and the upgrade button is enabled.

• Step 2 - Connect to a colony as a user without root permissions. Confirm the Calamity Banner is visible and the upgrade button is enabled.

Diffs

Deletions ⚰️

• Removed canUpgradeColony and related uses from useCalamityBannerInfo

Resolves #3340

[arrenv]

@iamsamgibbs Thank you for picking this up, sorry for the confusion on this issue as you have done the work already. @melyndav happened to not have Reputation enabled when running into this originally.

However, hiding the banner completely for everyone but root is not the desired behavior. As it could pose a security risk, and everyone should be informed of a new version.

We already handle permissions in the Upgrade colony version action, and we also allow a colony to be upgraded using Reputation.

So, the correct behavior here should be that the upgrade button is never disabled, and should always open the "Upgrade colony version" action.

Acceptance criteria

• Upgrade notice calamity banner should appear for everyone.
• Upgrade button should be enabled for all members.
• Clicking the upgrade button should open the "Upgrade colony version" action.

[arrenv]

As above.

[iamsamgibbs]

No problem Arren! Updated to match the new specs.

[rumzledz]

Smashed it Sam! 💪

1. Updated the canColonyBeUpgraded function to return true

2. Connected Leela's wallet (has root perms)

3. Connected Amy's wallet (has no root perms)

[rdig]

Nicely fixed! 💯

As leela (root)

As fry

[arrenv]

@iamsamgibbs Thank you, and sorry again for the mess around. Looks good to me :)