Fix: Set the non-mobile Toast width to 390px #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmioana
requested changes
Nov 1, 2024
There was a problem hiding this comment.
Nice work fixing the global width of the toast messages @rumzledz 🙌
All good with your fix, but now that we've touched these classes, it would be nice to use an already configured spacing class for the before pseudo-element's width 🥺
Once you push this change, I'll happily re-approve 🦾
| @@ -7,7 +7,7 @@ | |||
| } | |||
|
|
|||
| .Toastify__toast { | |||
| @apply relative mb-0 rounded-l-none rounded-r-lg border border-gray-200 bg-base-white p-6 shadow-lg before:absolute before:left-0 before:top-0 before:block before:h-full before:w-[0.375rem] before:content-[''] sm:min-w-[24.375rem]; | |||
| @apply relative mb-0 rounded-l-none rounded-r-lg border border-gray-200 bg-base-white p-6 shadow-lg before:absolute before:left-0 before:top-0 before:block before:h-full before:w-[0.375rem] before:content-[''] sm:w-[24.375rem]; | |||
There was a problem hiding this comment.
Can we please change before:w-[0.375rem] to before:w-1.5?
There was a problem hiding this comment.
Sure, your majesty 👑
rumzledz
force-pushed
the
fix/3573-user-acct-toast-styles
branch
from
2c52792 to
99b38ab
Compare
rdig
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A wee update to our Toast component's non-mobile container style. We're now setting it width: 390px to adhere to our Toast's global sizing based on Figma.
Testing
NotificationTypeToggle.tsxfile and add the following param to thetoast.successfunction:Resolves #3573