Feat: Add custom transactions action card #3849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bassgeta
approved these changes
Dec 5, 2024
jakubcolony
approved these changes
Dec 5, 2024
Comment on lines
+148
to
+153
| if (!isFeatureFlagArbitraryTxsEnabled) { | ||
| const arbitraryTxsIndex = actionsListOptions[4].options.findIndex( | ||
| ({ value }) => value === Action.ArbitraryTxs, | ||
| ); | ||
|
|
||
| actionsListOptions[4].options.splice(arbitraryTxsIndex, 1); |
There was a problem hiding this comment.
To remove the hardcoded array index, how about using array spread to dynamically add arbitrary transactions to the options array?
rdig
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the custom transactions card to the manage colony drawer and updates it in the action select dropdown.
Figma file: https://www.figma.com/design/l1dOM5qiQYwF0ElvKDqqjg/Design-System---Colony-v3?node-id=6111-2669&t=49uR3c8BmTwlpEbS-4
Testing
Diffs
New stuff ✨
Changes 🏗
Resolves #3844