Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

classNames should be className #3882

Merged
merged 1 commit into from
Dec 19, 2024
Merged

classNames should be className #3882

merged 1 commit into from
Dec 19, 2024

Conversation

chmanie
Copy link
Member

@chmanie chmanie commented Dec 9, 2024

Description

Otherwise our linter and tailwind won't pick it up properly.

Testing

Everything should look the same I guess?

Diffs

Changes 🏗

  • classNames is now className except when there's actually a different use case for it (e.g. ReactSelect)

@chmanie chmanie requested a review from a team as a code owner December 9, 2024 20:20
@chmanie chmanie self-assigned this Dec 9, 2024
@chmanie chmanie added the enhancement New feature or request label Dec 9, 2024
iamsamgibbs
iamsamgibbs approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tidy up Chris! Everything is still looking the same:

Screenshot 2024-12-10 at 10 27 05 Screenshot 2024-12-10 at 10 44 27 Screenshot 2024-12-10 at 10 44 58

rdig
rdig approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

mmioana
mmioana approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring this @chmanie 💯

All good from my side 🙌

Screenshot 2024-12-11 at 21 23 23
Screenshot 2024-12-11 at 21 23 56
Screenshot 2024-12-11 at 21 24 56
Screenshot 2024-12-11 at 21 27 25

@chmanie chmanie merged commit bdbaac9 into master Dec 19, 2024
2 checks passed
@chmanie chmanie deleted the maint/classnameclassnames branch December 19, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamsamgibbs iamsamgibbs iamsamgibbs approved these changes

@mmioana mmioana mmioana approved these changes

@rdig rdig rdig approved these changes

Assignees

@chmanie chmanie

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chmanie @rdig @mmioana @iamsamgibbs