Fix: Staged payments with locked tokens

[davecreaser]

Description

• Fix issues with making staged payment using tokens which are not native to your colony.
• Four issues are fixed here:
  • You should not be able to make a staged payment milestone using a token which is locked
  • When using a token for a milestone which is not your colonies native token, it needs to be passed to the transaction for it to be claimed properly (previously only the colony native token was being sent)
  • If a milestone payment failed for whatever reason, the status pill should not show as 'passed'
  • Duplicate milestones were appearing in the sidebar (related to them silently failing)

Testing

• Open Wayne Enterprises colony and check that the native token (GGG) is locked (this is the default state from the create-data script)

• Go to the Planet Express colony

• Open the incoming funds table and claim all incoming funds (there should by default be some GGG in there)

• Install the staged payments extension

• Make a staged payment, and for at least one of the milestones try to use GGG as the token. You should not be able to create the staged payment and a correct error should be shown.

• Go back to Wayne Enterprises and unlock the token using an unlock token action.

• Return to the Planet Express colony

• Make another staged payment, and again for at least one of the milestones try to use GGG as the token. You should now be able to create the staged payment and no error should be shown.

• Go through all the steps in the sidebar of the completed action panel for this staged payment and release all of the milestones (either one by one, or all at once, it shouldn't matter). There should be no issues with this, and no duplicate milestones being shown in the sidebar.

Diffs

Changes 🏗

• Fixed form validation of staged payments
• Fixed token addresses being passed in the payload to the staged payment saga
• Fixed styling of failed milestone claims for staged payments

Resolves #3899

[jakubcolony]

Nice work fixing this bunch of issues, everything working as described 👌

[mmioana]

Really nice work on this issue @davecreaser 🙌

The token in wayne is locked

Accepted all incoming funds in planex

Installed the Staged payments extension

Tried creating a Staged payment with one milestone using the ƓƓƓ token and the error message was displayed

Unlocked the ƓƓƓ token

Now the error message was no longer shown

Managed to create the Staged payment

Released the 1st milestone with CREDS

Released the 2nd milestone with ƓƓƓ

And everything was completed without any issues ✨

Nice job!!!

[iamsamgibbs]

Great job fixing up the form Dave! Followed your testing steps without issue: