Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Wrap long descriptions #3953

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

rumzledz
Copy link
Contributor

Description

wrap

Testing

  1. Bring up the Simple Payment form
  2. Enter the following text on the Description field:
jfkladfjkladfkldjlk;ajflkjadkl;fjadlk;fjadlk;fjkladsjflk;adjfkljadklfjadlkfjadkl;jflk;ajfkladjlf;jalk;fjadkl;fjakld;jfkladjl;adjlkdajflkadjfkljadklfjadlkfjkladjflk;adsjflkadsjflkadjfkladjfal;kfjklajfl;kadjflkadjflkadjfl;kajfl;kadjflk;adjfl;kadjfl;kdajflk;adjflkadjfkladjkfjadlk;fjlka;djfjadlk;jfkladjf;la
  1. Collapse the Description field
  2. Verify that the description is properly clamped to 2 lines and truncated
  3. Change the viewport to mobile
  4. Verify that it's still properly clamped and truncated

Resolves #2985

@rumzledz rumzledz self-assigned this Dec 16, 2024
@rumzledz rumzledz marked this pull request as ready for review December 16, 2024 19:04
@rumzledz rumzledz requested a review from a team as a code owner December 16, 2024 19:04
Copy link
Contributor

@bassgeta bassgeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

word break? break word! 🔥
Action form looks right ✔️
image
Completed action ✔️
image

Copy link
Contributor

@Nortsova Nortsova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for this fix ✨

image image

Copy link
Contributor

@davecreaser davecreaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple, works on both desktop and mobile 📈

Screenshot 2024-12-17 at 10 13 19 Screenshot 2024-12-17 at 10 13 28

It's a "wrap" 🥁

@melyndav
Copy link

@rumzledz the inital issue I raised was for handling URLs - #2985, and I don't see this as part of the testing for the PR. Can we ensure this is resolved before merging?

@rumzledz
Copy link
Contributor Author

rumzledz commented Dec 17, 2024

Hey @melyndav! The actual underlying issue was not URLs mainly -- it was that we didn't have a break rule for really long strings that don't have any spaces. So in the case of URLs such as this: docs.google.com/spreadsheets/d/1z2cWvpna-zDhAESATCG6L2aZdY6f0rUIegetC6mgHpI/edit?gid=0#gid=0, it was an issue.

But here goes for URLs 😄

Web Mobile
Screenshot 2024-12-17 at 19 56 44 image

@melyndav
Copy link

Hey @melyndav! The actual underlying issue was not URLs mainly -- it was that we didn't have a break rule for really long strings that don't have any spaces. So in the case of URLs such as this: docs.google.com/spreadsheets/d/1z2cWvpna-zDhAESATCG6L2aZdY6f0rUIegetC6mgHpI/edit?gid=0#gid=0, it was an issue.

But here goes for URLs 😄
Web Mobile
Screenshot 2024-12-17 at 19 56 44 image

Makes perfect sense @rumzledz, thanks for the reassurance that all is resolved, and my little worry is nothing haha ✌️

@rumzledz rumzledz merged commit 6347bcd into master Dec 17, 2024
2 checks passed
@rumzledz rumzledz deleted the fix/2985-wrap-long-descriptions branch December 17, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PROD] Mobile: Action descriptions fields don't wrap on mobile for long content
5 participants