Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed supported state copy #3988

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

CzarekDryl
Copy link
Contributor

@CzarekDryl CzarekDryl commented Dec 19, 2024

Description

  • Changed Staked motion text to Supported
image

Testing

Simple payment

  1. Ensure you have Reputation extension enabled.
  2. Create a Simple payment action.
  3. Use the Reputation decision method.
  4. Fully stake the motion.
  5. Check the status of the motion in the activity feed.

Advanced payment

  1. Ensure you have Reputation extension enabled.
  2. Create an Advanced payment action.
  3. Perform any step with the Reputation decision method. e.g. Funding.
  4. Check the status of the motion in the motion widget.

Resolves #3971

@CzarekDryl CzarekDryl self-assigned this Dec 19, 2024
@CzarekDryl CzarekDryl requested a review from a team as a code owner December 19, 2024 15:11
Copy link
Contributor

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple fix @CzarekDryl 💯

Created a Simple payment with reputation
Screenshot 2024-12-20 at 11 14 02

The Supported status is shown in the Activity table
Screenshot 2024-12-20 at 11 14 17

Created an Advanced payment and funded using Reputation
Screenshot 2024-12-20 at 11 15 17

Also checked the Activity page and the status is shown correctly 👍
Screenshot 2024-12-20 at 11 15 32

Copy link
Contributor

@Nortsova Nortsova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, status shows as expected: ✨
image

@CzarekDryl CzarekDryl merged commit 3f41291 into master Dec 23, 2024
2 checks passed
@CzarekDryl CzarekDryl deleted the fix/16212515-motion-text branch December 23, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix motion status to correct copy
3 participants